Page MenuHomeFreeBSD

Retire procfs-based process debugging.
ClosedPublic

Authored by jhb on Feb 25 2020, 5:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 20, 9:45 PM
Unknown Object (File)
Mon, Nov 18, 1:04 PM
Unknown Object (File)
Tue, Nov 5, 4:01 AM
Unknown Object (File)
Oct 19 2024, 12:29 AM
Unknown Object (File)
Oct 16 2024, 12:08 PM
Unknown Object (File)
Oct 2 2024, 5:44 PM
Unknown Object (File)
Oct 1 2024, 12:40 PM
Unknown Object (File)
Sep 29 2024, 11:06 PM

Details

Summary

Modern debuggers and process tracers use ptrace() rather than procfs
for debugging. ptrace() has a supserset of functionality available
via procfs and new debugging features are only added to ptrace().
While the two debugging services share some fields in struct proc,
they each use dedicated fields and separate code. This results in
extra complexity to support a feature that hasn't been enabled in the
default install for several years.

Test Plan
  • passes make tinderbox and ptrace_test tests

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 30033
Build 27844: arc lint + arc unit

Event Timeline

Note that there is a parent review to add a deprecation notice that is waiting for an exa-run. I will do a separate exp-run for this one after the first is committed since this removes the header entirely.

This revision is now accepted and ready to land.Feb 25 2020, 7:33 PM
kib added inline comments.
sys/amd64/amd64/vm_machdep.c
205

Isn't TDB_STOPATFORK enough, and even better for the same purpose ?

jhb marked an inline comment as done.Mar 20 2020, 12:01 AM

I've rebased the patch set, but need to let a tinderbox build finish. After that I will refresh the review and request an exp-run.

  • Rebase.
  • Drop comment about PTRACE_FORK.
  • Remove #warning workarounds.
  • Remove pioctl.h.
This revision now requires review to proceed.Mar 20 2020, 10:01 PM
This revision was not accepted when it landed; it landed in state Needs Review.Apr 2 2020, 4:02 AM
This revision was automatically updated to reflect the committed changes.