Page MenuHomeFreeBSD

Use standard pattern for stdargs
ClosedPublic

Authored by imp on Feb 11 2018, 5:26 PM.

Details

Summary

mips stdargs.h has all kinds of junk for really old compilers. gcc 3 was released in 2001, so we don't need support for pre-gcc3 anymore. When you remove it, there's nothing left except for code that's a poorer version of sys/_stdarg.h. Migrate to that. In fact, sparc64 and powerpc could use the same.

Test Plan

I'm just doing a buildworld :) worked for mipsel, mips64, powerpc64, sparc64

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

imp created this revision.Feb 11 2018, 5:26 PM
imp edited the summary of this revision. (Show Details)Feb 11 2018, 5:30 PM
imp edited the test plan for this revision. (Show Details)
imp added a comment.Feb 11 2018, 6:08 PM

I'll note that phk suggests that mips can't use this file in his initial commit, but I see no reason why it can't.

imp added a comment.Feb 11 2018, 6:09 PM

buildworld mips64 and mipsel completes w/o error

imp updated this revision to Diff 39193.Feb 11 2018, 10:22 PM
imp edited the summary of this revision. (Show Details)

sparc and powerpc too

imp retitled this revision from Use standard pattern for varargs to Use standard pattern for stdargs.Feb 11 2018, 10:24 PM
imp edited the summary of this revision. (Show Details)
imp edited the test plan for this revision. (Show Details)
imp added reviewers: nwhitehorn, jhibbits, marius.
imp updated this revision to Diff 39195.Feb 11 2018, 10:35 PM
imp edited the summary of this revision. (Show Details)
  • We don't support gcc < 4.2.1, so varargs.h now is just #error
kan accepted this revision.Feb 12 2018, 3:10 AM
kan added a subscriber: kan.

no objection

This revision is now accepted and ready to land.Feb 12 2018, 3:10 AM
jhibbits accepted this revision.Feb 12 2018, 3:41 AM

If it builds, ship it.

This revision was automatically updated to reflect the committed changes.