Differential D14048

Modify handling of TCP_RFC7413 (TFO) kernel option
ClosedPublic
Actions

Authored by pkelsey on Jan 25 2018, 7:09 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sep 28 2024, 4:16 AM

	Unknown Object (File)
	Sep 26 2024, 11:51 AM

	Unknown Object (File)
	Sep 25 2024, 9:27 PM

	Unknown Object (File)
	Sep 25 2024, 10:37 AM

	Unknown Object (File)
	Sep 20 2024, 11:13 AM

	Unknown Object (File)
	Sep 19 2024, 1:31 PM

	Unknown Object (File)
	Sep 14 2024, 3:26 PM

	Unknown Object (File)
	Sep 9 2024, 12:17 PM

View All 48 Files

Subscribers

Details

Reviewers

glebius
j-nitrology.com
jason_eggnet.com
jtl
hiren
kbowling
tuexen

Group Reviewers

Commits

rS330002: Greatly reduce the number of #ifdefs supporting the TCP_RFC7413 kernel option.

Summary

Greatly reduce the number of #ifdefs supporting the TCP_RFC7413 kernel option. The conditional compilation support is now centralized in tcp_fastopen.h and tcp_var.h. This doesn't provide the minimum theoretical footprint when TCP_RFC7413 is disabled, but nearly all the TFO code should wind up being removed by the optimizer, the additional footprint in the syncache entries is a single pointer, and the additional overhead in the tcpcb is at the end of the structure.

This enables TCP_RFC7413 by default in amd64 and arm64 GENERIC.

This revision depends on D14047.

Test Plan

Tested build with and without option TCP_RFC7413 in the kernel config.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 14572

Event Timeline

pkelsey created this revision.Jan 25 2018, 7:09 AM

Herald added a reviewer: transport. · View Herald TranscriptJan 25 2018, 7:09 AM

Herald added subscribers: emaste, andrew, imp. · View Herald Transcript

People wanting to disable tfo (for whatever reasons) may have different opinions but looks good to me on a quick glance. Thanks.

Going to commit this soon as the review has been open for nearly one month and has been idle for two weeks.

This revision was not accepted when it landed; it landed in state Needs Review.Feb 26 2018, 3:03 AM

Closed by commit rS330002: Greatly reduce the number of #ifdefs supporting the TCP_RFC7413 kernel option. (authored by pkelsey). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

amd64/

conf/

1 line

arm64/

conf/

1 line

netinet/

19 lines

30 lines

20 lines

10 lines

2 lines

22 lines

23 lines

2 lines

Diff 38434

sys/amd64/conf/GENERIC

Loading...

sys/arm64/conf/GENERIC

Loading...

sys/netinet/tcp_fastopen.h

Loading...

sys/netinet/tcp_input.c

Loading...

sys/netinet/tcp_output.c

Loading...

sys/netinet/tcp_subr.c

Loading...

sys/netinet/tcp_syncache.h

Loading...

sys/netinet/tcp_syncache.c

Loading...

sys/netinet/tcp_usrreq.c

Loading...

sys/netinet/tcp_var.h

Loading...