In D23300#614738, @dvl wrote:

In D23300#614246, @missoline_protonmail.com wrote:

Is anyone working on this?

I have been told that future/current release has some nasty stuff in it which doesn't work on FreeBSD. They have chosen to use Ubuntu and while they have previously worked to have this compatible with FreeBSD, that has ended. I am basing this on 2nd hand conversations with people I trust.

In D23300#614738, @dvl wrote:

In D23300#614246, @missoline_protonmail.com wrote:

Is anyone working on this?

I have been told that future/current release has some nasty stuff in it which doesn't work on FreeBSD. They have chosen to use Ubuntu and while they have previously worked to have this compatible with FreeBSD, that has ended. I am basing this on 2nd hand conversations with people I trust.

Just an FYI the DotNet Core guys are ramping up as well:

In D23300#614246, @missoline_protonmail.com wrote:

Is anyone working on this?

In D23300#614246, @missoline_protonmail.com wrote:

Is anyone working on this?

Just going to post this workaround here since this is one of the top Google results / a lot of links point here when you're looking for mono upgrade solutions and manually compiling on each of your jails or anything along those lines can be quite tedious.
This thread has the secondary packages needed in order to install mono 6.8, as well as someone posted the mono-6.8.0.105 patch pre-built to GitHub for ease of download.
The excerpt steps are below:

I realise this doesn't fix your longtime problem, but for now (while the maintainer situation is taken care of) there is working fix at https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238089 :

If there is something we can do to accelerate the merging, please let us know. We are in the process of migrating all our workstations to FreeBSD, but the lack of a recent mono version is blocking and so critical that we may have to move to Linux instead, this would be a shame. A recent mono is indeed now required to have a development environment for csharp on Unix (omnisharp-roslyn requires mono version 6.4.0 at least. For context: omnisharp-roslyn is the backend providing IDE-like features for csharp to all text editors).

Is anyone working on this?

I have had to actively avoid using FreeBSD at times because of the lack of Mono or .Net Core support. PLEASE someone push SOMETHING. I would be happy to jump back into supporting Mono and help get the .Net Core to build natively on FreeBSD.

I don't mean to spam/bump, so I apologize if this is interpreted that way.
I am just asking if anyone has plans to accelerate the merging of this review (and the necessary changes), since it has been around for quite some time (the bugs.freebsd.org port has been since 05-24-2019 and this since 01-21-2020 while the version still active on FreeBSD is incredibly dated (~5.10.1.57) and actually won't work for a few of my services. I would manually install the patched port files for my systems, but it's not practical to maintain for > 1 jail (let alone 8+ jails). 😛
If there are no active plans (which is okay, of course), I will start making plans to move my systems away from using FreeBSD as the host to a more containerized system (i.e. Docker/VM instead of my current Jails), and just want to know if that is going to be necessary! 🙂

The options block is badly ordered, See https://www.freebsd.org/doc/en/books/porters-handbook/porting-order-options.html for the correct ordering of the variables.

When last talking to Philip 3-4 weeks ago I had shown that I had been able to compile his previous patch on all the various archs. The latest version does not. We have not yet agreed on whether we should simply commit the previous patch yet. I will talk to him.

I just read about the pillow PR.

Any chance this is going to get merged? I was running a version of this for a long time and it was working flawlessly for my Mono services, but since rolling back I'm hitting so many annoying bugs in the old version of Mono.

The submitter of ports/238089 has asked for py-pillow to be removed from dependencies unless mono-heapviz is used, as it's a heavy dependency:

fwiw I have been working closely with the submitter over the past few weeks. I have tested both the previous version of this patch as well as the current one.

@crees: Feel free to get this. I took it only because I read on IRC that this review needed attention, but I don't know much about mono and you will surely do a better work than me.
However you should probably take a look at https://reviews.freebsd.org/D24988 , which tries to improve this patch.

Is this OK for you two? @salvadore, if you commit this, please make sure you close https://bugs.freebsd.org/238089?

Bump to 6.8.0.123 (still the 2019-10 branch), clean things up a bit more.

Looking at the diff between pkg-plist and pkg-plist.powerpc, I noticed I missed this at the end of pkg-plist.powerpc:

In D23300#537392, @greg_unrelenting.technology wrote:

@salvadore the aarch64-btls patch should be updated to https://patch-diff.githubusercontent.com/raw/mono/boringssl/pull/23.diff

@salvadore the aarch64-btls patch should be updated to https://patch-diff.githubusercontent.com/raw/mono/boringssl/pull/23.diff

@tobik : you are right. I won't commit it blindly even it has already been approved and I will review it carefully. Thanks!

In D23300#537062, @pkubaj wrote:

In D23300#537043, @salvadore wrote:

Time has come that someone commits this accepted review.

I am a mentored committer so I can do it once my mentors give me approval.
@gerald, @tcberner: Can I proceed?

Don't forget about pkg-plist.powerpc that I attached.

In D23300#537043, @salvadore wrote:

Time has come that someone commits this accepted review.

I am a mentored committer so I can do it once my mentors give me approval.
@gerald, @tcberner: Can I proceed?

Time has come that someone commits this accepted review.

How close are we to getting this committed? Are there still some open points or is it fine as is ATM?

In D23300#530928, @greg_unrelenting.technology wrote:

In D23300#530926, @mikael wrote:

It builds fine on aarch64, nice work!

hm, was that not on -current? I see the ifndef ID_AA64ISAR0_AES_VAL stuff from my github PR didn't make it here yet

In D23300#530926, @mikael wrote:

It builds fine on aarch64, nice work!

It builds fine on aarch64, nice work!

Builds fine, but I still have pkg-plist errors, probably because of missing pkg-plist.powerpc. And since this file is missing, all the files that are installed are orphaned.

Noting here that as of today, all patches to 6.8.0.105 have been upstreamed
https://github.com/mono/boringssl/pull/23
https://github.com/mono/mono/pull/19234

In D23300#529892, @pkubaj wrote:

It doesn't apply after r526962:

In D23300#529872, @prj_rootwyrm.com wrote:

@greg_unrelenting.technology - your patch should ONLY need to touch external/boringssl/crypto/cpu-aarch64-linux.c at this point, but I can't test here. If that's the case, can you please submit a PR with it to https://github.com/mono/boringssl ?

It doesn't apply after r526962:

pkubaj@talos:$/usr/ports/lang/mono$ doas svn patch D23300.diff
C         Makefile
>         rejected hunk @@ -2,94 +2,118 @@
U         distinfo
A         files/patch-btls-aarch64
D         files/patch-configure.ac
D         files/patch-mcs_class_Mono.Security_Mono.Security.Cryptography_KeyPairPersistence.cs
D         files/patch-mcs_class_Mono.Security_Mono.Security.X509_X509StoreManager.cs
D         files/patch-mcs_tools_mono-configuration-crypto_lib_Mono.Configuration.Crypto_KeyContainerCollection.cs
D         files/patch-mcs_tools_xbuild_data_12.0_Microsoft.CSharp.targets
D         files/patch-mcs_tools_xbuild_data_14.0_Microsoft.CSharp.targets
A         files/patch-mono_configure.ac
D         files/patch-mono_eglib_gfile-posix.c
A         files/patch-mono_metadata_Makefile.am
G         files/patch-mono_mini_Makefile.am.in
>         hunk @@ -1,11 +0,0 @@ already applied
D         files/patch-mono_mini_tramp-amd64.c
D         files/patch-mono_utils_mono-context.h
D         files/patch-mono_utils_mono-threads.c
D         files/patch-scripts_mono-heapviz
U         pkg-message
U         pkg-plist
A         pkg-plist.powerpc
Summary of conflicts:
  Text conflicts: 1

Apologies for the apparent radio silence; I've actually been working on some high priority issues in upstream and trying to sort out inotify. The patch issue with ppc64 was actually just an SVN hiccup. Upstream patch is correct and will be in next release. This should be ready to go for ppc64 and aarch64.
@greg_unrelenting.technology - your patch should ONLY need to touch external/boringssl/crypto/cpu-aarch64-linux.c at this point, but I can't test here. If that's the case, can you please submit a PR with it to https://github.com/mono/boringssl ?

It still fails with:

• Reorder Makefile and expand to svn diff -x -U999999 as requested by @mat
• Fixed typo in files/patch-powerpc64; this now matches powerpc*-*-freebsd* as in upstream
• Correctly mark BROKEN for QEMU_EMULATING; Roslyn is very picky about POSIX and does not like qemu
• Fix .if ${ARCH} PLIST handling by switching to pre/post.mk; accurate plists are still needed for ppc64 ELFv1, arm*, and arm64* This is based on https://reviews.freebsd.org/D22451
• Remove "EXPERIMENTAL" from Ninja; this is well-tested and perfectly safe. It will remain non-default because of the number of dependencies it pulls in.
• Remove 'TZ' from MAKE_ENV; this actually hasn't been necessary for a while
• Correct branch comment; 6.8.0.105 is actually branch 2020-02

Also, could you use devel/arcanist, or at least generate a diff with full context like it does, with svn diff -x -U9999 or git diff -U9999.

In D23300#518554, @pkubaj wrote:

On powerpc64, I'm still getting:

configure: error: unknown target

This is because in configure.ac, there's neither powerpc64-*-freebsd, nor powerpc*-*-freebsd:

On powerpc64, I'm still getting:

configure: error: unknown target

This is because in configure.ac, there's neither powerpc64-*-freebsd, nor powerpc*-*-freebsd:

This diff should resolve the plist issue fully and much more correctly.

! In D23300#518091, @driesm.michiels_gmail.com wrote:

This last version update has some plist issues for me as well (amd64 on STABLE12). Please check with Poudriere for QA before updating the diff. If possible. ;-).

In D23300#517570, @prj_rootwyrm.com wrote:

• Update to 6.8.0.105
• Includes fix for powerpc64 building (patch has been upstreamed)
• Includes @greg_unrelenting.technology 's patch partially; testing is required here. All of the Mono changes were already done upstream except for the boringssl portion. Some were done slightly differently (e.g. REDZONE is for all !APPLE) and revisions were necessary to boehm being deprecated/externalized.

The issue with MCS/CSC insta-crashing on qemu is a known issue due to qemu limitations and Roslyn behaviors, so if anyone knows how I can say "aarch64 as long as it's not qemu" that would be very helpful. Users on qemu should expect this port to NOT build, while users on native arm should have no issues.