In D55453#1269653, @brooks wrote:

@vexeduxr please commit with kib's suggestion

s/tmpdir/tmpmnt

In D55469#1269614, @jrtc27 wrote:

Can you please include an appropriate description of the effects in the commit message?

Add comments explaining the missing header guard and the use of SIZE_TYPE

In D55453#1269284, @brooks wrote:

I don't think the commit text is specific enough about the cause. You should point to a specific combination that fails, not claim its is was macOS only (I'm fairly sure I added this due to testing cross build on ubuntu).

Add comment noting that the ESP is mounted.
Rename ZFS mirror loop variable so mntpt can be reused.

Provide the full loader path as an argument, instead of just the file name.

In D55469#1269123, @jrtc27 wrote:

What is the effect of this bug?

It happens if anything other than __need_size_t is defined. Some headers include stddef.h but don't want the whole thing, so they define __need_*. The header can also be included multiple times with different __need_* macros defined.
This is all internal of course, simply including stddef.h with nothing defined gives you the whole thing.

Only pass -malign-double for the 32-bit build.
Suffix 32-bit EFI libraries with efi

Look okay to me.

In D55140#1264432, @quentin.thebault_defenso.fr wrote:

In D55140#1264381, @vexeduxr wrote:

splash is set to /boot/images/freebsd-logo-rev.png by default. Should the same be done for the shutdown splash?

This is already the case since we call into the existing vtterm_splash code where this case is handled.

splash is set to /boot/images/freebsd-logo-rev.png by default. Should the same be done for the shutdown splash?

Looks okay to me.

Only assign "gop" if the framebuffer type is FB_GOP.

In D53413#1219714, @cperciva wrote:

Does this work with cross-builds? I suspect that WSTAGEDIR is getting set to "" and then you're setting PKG_ABI based on /usr/bin/uname in the host system.

In D52305#1219629, @jhb wrote:

Sorry I missed this earlier. Please merge into 15.0 if possible.

On Sat Oct 11, 2025 at 2:26 AM +0300, Steve Kargl wrote:

I do not have a phabricator account. That method to
review patches came after I stopped committing.

I did look at your patch, and do believe that it
is the correct fix. If you compare to remainderf(),
you'll see that the float version considers the
entire significand. I also checked remainderl().
It calls remquol() and it's implementation is
much different than the float and double versions.

Will do. I tried to add him to the review before uploading the patch but couldn't find an account.