On Sat Oct 11, 2025 at 2:26 AM +0300, Steve Kargl wrote:

I do not have a phabricator account. That method to
review patches came after I stopped committing.

I did look at your patch, and do believe that it
is the correct fix. If you compare to remainderf(),
you'll see that the float version considers the
entire significand. I also checked remainderl().
It calls remquol() and it's implementation is
much different than the float and double versions.

Will do. I tried to add him to the review before uploading the patch but couldn't find an account.

Allocate fifo before locking priv->mtx

malloc priv->events with the correct size

I don't have the hardware to test this, but cross referencing the documentation, it looks good to me.

Bump
Userspace GPIO interrupts are currently broken because of this. (after D51932)
I believe that we do need to implement the resource allocation functions too (for cross-tree consumers), just not on the GPIO controller.

No problem :)

LGTM, just one nit.

No worries.

I got toolchain errors when running the script for amd64, but I verified that it does actually build with MK_LOADER_BIOS_TEXTONLY=no on amd64.

Bumping
This seems important, should make it to 15.0

Return actual errno values in other code paths.

The BIOS loader uses -Wall, but I'm not sure about the rest.

Ah, I don't mind. :)

In D50995#1164515, @bz wrote:

Lastly contrib/llvm-project/libcxx/include/__bit/popcount.h says:

"__builtin_popcountg is available since Clang 19 and GCC 14"

No idea what our bare minimum is.

Remove redundant initialization

Most errors generated by this are trivial to fix. I just opened reviews for the ones that weren't.

This fixes the BUS_DELETED_CHILD call for acpi_gpiobus. I think it might be papering over a bug though.
When device_delete_child is called, say with device_delete_child(gpio0, gpiobus0), it calls device_detach on gpiobus0. It then goes through it's children and recursively calls device_delete_child on them. When one of these children reach the BUS_CHILD_DELETED call, gpiobus0 has already been detached, so the call never reaches it's implementation.

The inline comments are in wildly incorrect places now, I'm not sure if I can fix that.

The new files (excluding the makefiles) are missing licenses.