Page MenuHomeFreeBSD

prepare-commit-msg: Sync with committers guide
AcceptedPublic

Authored by ziaee on Wed, Jan 14, 1:28 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jan 26, 8:57 PM
Unknown Object (File)
Sun, Jan 25, 8:40 AM
Unknown Object (File)
Sat, Jan 24, 6:17 AM
Unknown Object (File)
Fri, Jan 23, 5:23 AM
Unknown Object (File)
Tue, Jan 20, 11:04 AM
Unknown Object (File)
Sun, Jan 18, 3:08 PM
Unknown Object (File)
Thu, Jan 15, 8:23 PM
Unknown Object (File)
Thu, Jan 15, 7:13 PM
Subscribers

Details

Summary

Add Discussed with:, Closes:, MFC to:, and Co-authored-by: to
the commit message template from the committer's guide. While here,
wordsmith these to fit on standard console.

Reported by: lwhsu

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 69874
Build 66757: arc lint + arc unit

Event Timeline

ziaee requested review of this revision.Wed, Jan 14, 1:28 PM
ziaee created this revision.
jlduran added inline comments.
tools/tools/git/hooks/prepare-commit-msg
51

What's the current status regarding Fixes:

# Fixes:		<git log -n1 --format:'%h ("%s")' GIT-COMMIT-HASH>
tools/tools/git/hooks/prepare-commit-msg
51

I do not know about this; this is a pre-existing issue out of scope of this commit. If we have a consensus I'm happy to use that, but 1. that command didn't work on my box and 2. shouldn't hold up trying to keep other stuff up to date.

tools/tools/git/hooks/prepare-commit-msg
51

git log -n1 --format='%h ("%s")' __hash__

tools/tools/git/hooks/prepare-commit-msg
51

Great, here's a review fixing that, thanks.

https://reviews.freebsd.org/D55121

Now may I fix what is in this commit?

This revision is now accepted and ready to land.Fri, Feb 6, 2:33 PM