ng_tty: avoid the sign extention of char
ClosedPublic
Actions

Authored by vexeduxr on Mon, Jan 5, 11:37 PM.

Details

Reviewers

glebius
kevans
imp
julian

Commits

rGda358db1cba7: ng_tty: avoid the sign extention of char
rG00d2b1b0c4d4: ng_tty: avoid the sign extention of char
rGc72aa343a620: ng_tty: avoid the sign extention of char
rG9b2478f60bfd: ng_tty: avoid the sign extention of char

Summary

When c is compared to sc->hotchar, both undergo integer promotion, which
can lead to c being sign extended. Fix this by casting c to an unsigned
char.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

vexeduxr created this revision.Mon, Jan 5, 11:37 PM

Herald added subscribers: melifaro, donner. · View Herald TranscriptMon, Jan 5, 11:37 PM

vexeduxr requested review of this revision.Mon, Jan 5, 11:37 PM

Harbormaster completed remote builds in B69639: Diff 169139.Mon, Jan 5, 11:37 PM

kevans accepted this revision.Tue, Jan 6, 12:26 AM

This revision is now accepted and ready to land.Tue, Jan 6, 12:26 AM

Closed by commit rG9b2478f60bfd: ng_tty: avoid the sign extention of char (authored by vexeduxr). · Explain WhyTue, Jan 6, 2:23 AM

This revision was automatically updated to reflect the committed changes.

vexeduxr added a commit: rG9b2478f60bfd: ng_tty: avoid the sign extention of char.

vexeduxr added a commit: rGc72aa343a620: ng_tty: avoid the sign extention of char.Wed, Jan 14, 12:55 AM

vexeduxr added a commit: rG00d2b1b0c4d4: ng_tty: avoid the sign extention of char.

vexeduxr added a commit: rGda358db1cba7: ng_tty: avoid the sign extention of char.Wed, Jan 14, 12:57 AM

Revision Contents
Changeset List

Path

Size

sys/

netgraph/

ng_tty.c

3 lines

Diff 169151

View Options

ng_tty: avoid the sign extention of charClosedPublicActions