Page MenuHomeFreeBSD

gpiobus: use bus_generic_detach when detaching
Needs ReviewPublic

Authored by vexeduxr on Aug 31 2025, 2:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Oct 11, 3:18 AM
Unknown Object (File)
Fri, Oct 10, 3:03 PM
Unknown Object (File)
Mon, Sep 29, 10:01 AM
Unknown Object (File)
Tue, Sep 23, 10:25 AM
Unknown Object (File)
Mon, Sep 22, 5:16 PM
Unknown Object (File)
Sep 16 2025, 5:27 AM
Unknown Object (File)
Sep 16 2025, 5:21 AM
Unknown Object (File)
Sep 13 2025, 5:55 AM
Subscribers
None

Details

Reviewers
imp
jhb
Summary

Use bus_generic_detach instead of bus_detach_children so the children
actually get deleted.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 66713
Build 63596: arc lint + arc unit

Event Timeline

vexeduxr created this revision.

This fixes the BUS_DELETED_CHILD call for acpi_gpiobus. I think it might be papering over a bug though.
When device_delete_child is called, say with device_delete_child(gpio0, gpiobus0), it calls device_detach on gpiobus0. It then goes through it's children and recursively calls device_delete_child on them. When one of these children reach the BUS_CHILD_DELETED call, gpiobus0 has already been detached, so the call never reaches it's implementation.