gpiobus: use bus_generic_detach when detaching
ClosedPublic
Actions

Authored by vexeduxr on Aug 31 2025, 2:45 PM.

Details

Reviewers

imp
jhb

Commits

rGb090bce56d52: gpiobus: use bus_generic_detach when detaching
rG330b4f470280: gpiobus: use bus_generic_detach when detaching

Summary

Use bus_generic_detach instead of bus_detach_children so the children
actually get deleted.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

vexeduxr requested review of this revision.Aug 31 2025, 2:45 PM

vexeduxr created this revision.

Harbormaster completed remote builds in B66713: Diff 161289.Aug 31 2025, 2:46 PM

This fixes the BUS_DELETED_CHILD call for acpi_gpiobus. I think it might be papering over a bug though.
When device_delete_child is called, say with device_delete_child(gpio0, gpiobus0), it calls device_detach on gpiobus0. It then goes through it's children and recursively calls device_delete_child on them. When one of these children reach the BUS_CHILD_DELETED call, gpiobus0 has already been detached, so the call never reaches it's implementation.