Fix make release with -DNOPKGBASE

[olivier]

Summary

Problem: When building FreeBSD release with -DNOPKGBASE, the build failed because PKG_ABI was undefined, leading to pkg commands with empty ABI parameters (-o ABI=).

Root Cause: The PKG_ABI variable was only defined inside the !defined(NOPKGBASE) conditional block, but pkg installation commands were still executed in NOPKGBASE mode.

Solution: Moved the PKG_ABI definition (and its dependencies WSTAGEDIR and PKG_ABI_FILE) outside the NOPKGBASE condition and into the !defined(NOPKG) condition, so it's defined whenever packages need to be installed, regardless of whether pkgbase is used or not.

Notice: All troubleshooting and patch made by claude code.

Test Plan

Before:

$ sudo make -C release -DNOPORTS -DNODOC -DNOSRC -DNOPKGBASE memstick -j $(nproc)
(etc.)
pkg: Unknown OS '' in ABI string
pkg: Cannot parse configuration file!
*** [disc1] Error code 1

After:

$ sudo make -C release -DNOPORTS -DNODOC -DNOSRC -DNOPKGBASE memstick -j $(nproc)
(etc.)
$ ls /usr/obj/usr/src/amd64.amd64/release/memstick.img
/usr/obj/usr/src/amd64.amd64/release/memstick.img

[cperciva]

Does this work with cross-builds? I suspect that WSTAGEDIR is getting set to "" and then you're setting PKG_ABI based on /usr/bin/uname in the host system.

Why are we using PKG_ABI with NOPKGBASE?

[olivier]

(adding context)

[emaste]

Makefile

82

We still need pkg to be usable if NOPKG is set (it just controls 3rd party packages)

[ivy]

In D53413#1219714, @cperciva wrote:

Does this work with cross-builds? I suspect that WSTAGEDIR is getting set to "" and then you're setting PKG_ABI based on /usr/bin/uname in the host system.

when packages aren't being built (e.g. with -DNOPKGBASE), worldstage is never populated at all, right? the release just installs directly from objdir into the release image.

[olivier]

In D53413#1219714, @cperciva wrote:

Does this work with cross-builds? I suspect that WSTAGEDIR is getting set to "" and then you're setting PKG_ABI based on /usr/bin/uname in the host system.

Why are we using PKG_ABI with NOPKGBASE?

No idea why PKG is used with NOPKGBASE, I’m discovering the Makefile.

[vexeduxr]

In D53413#1219714, @cperciva wrote:

Does this work with cross-builds? I suspect that WSTAGEDIR is getting set to "" and then you're setting PKG_ABI based on /usr/bin/uname in the host system.

It points to ${OBJTOP}/worldstage either way, but like @ivy mentioned, it doesn't exist if we're building with NOPKGBASE.

I think the correct fix would be to remove the ABI argument when we're building with NOPKGBASE see, P681.
That patch also fixes the installation of packages in VM_EXTRA_PACKAGES with -DNOPKGBASE.