Page MenuHomeFreeBSD

skibo (Thomas Skibo)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 1 2016, 4:34 PM (231 w, 4 d)

Recent Activity

Sat, Aug 1

skibo updated the diff for D24304: Add 64-bit support to Cadence CGEM Ethernet driver..

Incorporate suggested fixes to man page.

Sat, Aug 1, 5:28 PM

Fri, Jul 31

skibo updated the diff for D24304: Add 64-bit support to Cadence CGEM Ethernet driver..

Simplify support for 64-bit systems.
This diff got ugly because I was trying to support the case of a 32-bit
device in a 64-bit kernel. But, I don't think that would work anyway and
I think it's safe to assume that any 64-bit system (arm64 or riscv64) will
have a 64-bit capable gem core. Also, I have added support for using the
clock infrastructure for changing the transmit reference clock which I need
for my zynqmp implementation.

Fri, Jul 31, 4:12 PM

May 20 2020

skibo updated the diff for D14429: Support single core Zynq devices (MiniZed)..

Add device id definitions to zy7_slcr.h and clean up style and white-spaces.

May 20 2020, 5:39 PM
skibo added inline comments to D14429: Support single core Zynq devices (MiniZed)..
May 20 2020, 3:40 PM

May 19 2020

skibo added a comment to D14429: Support single core Zynq devices (MiniZed)..
In D14429#548577, @jmg wrote:

Thanks, tried to do this from FreeBSD, but couldn't figure out how to dump the entire register:

Zynq> md 0xf8f00004 1
f8f00004: 00000511                               ....
Zynq> md 0xf8000530 1
f8000530: 13723093                               .0r.

Hmm.. that sysctl didn't work, but there was pssid:

freebsd@generic:~ % sysctl hw.zynq.pssid
hw.zynq.pssid: 0x13723093: manufacturer: 0x49 device: 0x3 family: 0x1b sub-family: 0x9 rev: 0x1
May 19 2020, 10:32 PM
skibo updated the diff for D14429: Support single core Zynq devices (MiniZed)..

Check SLCR.PSS_IDCODE to determine if this is a single-core Zynq chip.

May 19 2020, 10:22 PM
skibo added a comment to D14429: Support single core Zynq devices (MiniZed)..
In D14429#548354, @jmg wrote:

I just tested this on my Cora Z7-07S board, and it looks like there's a hardware bug that prevents this patch from working.

I added a printf to dump mp_maxid and mp_ncpus, and I get 1 and 2 respectively, which per the TRM indicates that it's suppose to have 2 cpus instead of 1.

May 19 2020, 2:33 PM

Apr 22 2020

skibo updated the diff for D24304: Add 64-bit support to Cadence CGEM Ethernet driver..

Pull URL to next line in if_cgem_hw.h.

Apr 22 2020, 6:17 PM
skibo added a comment to D24304: Add 64-bit support to Cadence CGEM Ethernet driver..

I am a little dubious about the many instances of #if INTPTR_MAX == INT64_MAX compile-time gymnastics.

Apr 22 2020, 6:08 PM

Apr 21 2020

skibo updated the diff for D24304: Add 64-bit support to Cadence CGEM Ethernet driver..

Remove some local changes that leaked into last update.

Apr 21 2020, 5:26 PM
skibo updated the diff for D24304: Add 64-bit support to Cadence CGEM Ethernet driver..

Tweak cgem description in config files. Correct man page with regards to which
devices the rxhangwar is enabled.

Apr 21 2020, 5:18 PM

Apr 17 2020

skibo added inline comments to D24436: Add genet driver for Raspberry Pi 4B Ethernet.
Apr 17 2020, 8:28 PM

Apr 5 2020

skibo created D24304: Add 64-bit support to Cadence CGEM Ethernet driver..
Apr 5 2020, 6:17 PM
skibo updated the diff for D23194: Add support for booting into kdb on arm64 platforms..

Update stale patch.

Apr 5 2020, 2:55 PM · arm64

Mar 30 2020

skibo added a comment to D24226: Cadence GEM driver style clean-up..

Ok, roast me!

Mar 30 2020, 6:36 PM
skibo created D24226: Cadence GEM driver style clean-up..
Mar 30 2020, 6:30 PM

Mar 27 2020

skibo updated the diff for D24207: Support PL-connected Ethernet on Zynq platforms..

Change clk_reg_val to uint32_t.

Mar 27 2020, 10:29 PM
skibo created D24207: Support PL-connected Ethernet on Zynq platforms..
Mar 27 2020, 10:20 PM

Jan 22 2020

skibo created D23319: An SPI driver for Zynq platforms.
Jan 22 2020, 6:49 PM

Jan 17 2020

skibo added inline comments to D14698: [new driver] zilinx/zy7_qspi: Add a qspi driver for Zynq platforms..
Jan 17 2020, 5:48 AM · ARM
skibo updated the diff for D14698: [new driver] zilinx/zy7_qspi: Add a qspi driver for Zynq platforms..

Remove mx25l from GENERIC conf. Tweak compatible strings for flash memory in zedboard/zynq .dts files so that devd can find the mx25l module.

Jan 17 2020, 5:42 AM · ARM

Jan 16 2020

skibo added inline comments to D14698: [new driver] zilinx/zy7_qspi: Add a qspi driver for Zynq platforms..
Jan 16 2020, 11:29 PM · ARM
skibo updated the summary of D23194: Add support for booting into kdb on arm64 platforms..
Jan 16 2020, 5:30 PM · arm64
skibo added a comment to D22060: Fixes and updates to Zynq u-boot ports.

I'll look into submitting the fix to u-boot but it won't appear until 2020.04.

Jan 16 2020, 5:19 PM

Jan 15 2020

skibo abandoned D22060: Fixes and updates to Zynq u-boot ports.

This diff is no longer valid because the Zynq u-boot ports have been removed.

Jan 15 2020, 8:57 PM
skibo created D23194: Add support for booting into kdb on arm64 platforms..
Jan 15 2020, 8:03 PM · arm64

Nov 28 2019

skibo updated the diff for D14429: Support single core Zynq devices (MiniZed)..

Minor style tweaks and whitespace clean-up.

Nov 28 2019, 12:19 AM

Nov 27 2019

skibo updated the diff for D14698: [new driver] zilinx/zy7_qspi: Add a qspi driver for Zynq platforms..

Add device to GENERIC kernel.

Nov 27 2019, 8:47 PM · ARM
skibo added inline comments to D14698: [new driver] zilinx/zy7_qspi: Add a qspi driver for Zynq platforms..
Nov 27 2019, 8:19 PM · ARM
skibo added inline comments to D14698: [new driver] zilinx/zy7_qspi: Add a qspi driver for Zynq platforms..
Nov 27 2019, 6:44 PM · ARM
skibo updated the diff for D14698: [new driver] zilinx/zy7_qspi: Add a qspi driver for Zynq platforms..

Fix tiny regression in documentation reference.

Nov 27 2019, 6:41 PM · ARM
skibo updated the diff for D14698: [new driver] zilinx/zy7_qspi: Add a qspi driver for Zynq platforms..

Style changes.

Nov 27 2019, 6:26 PM · ARM
skibo updated the diff for D14698: [new driver] zilinx/zy7_qspi: Add a qspi driver for Zynq platforms..

I had the incorrect clock value for Zybo. It uses a 200 Mhz reference clock just like the Zedboard. So put default reference clock value and spi clock value into zynq-7000.dtsi

Nov 27 2019, 12:01 AM · ARM

Oct 18 2019

skibo added a comment to D22060: Fixes and updates to Zynq u-boot ports.

Also, u-boot-master/Makefile creates a boot.scr for all arm boards but the zynq boards ignore it and don't need it. Should we come up with an exception for zynq boards?

Oct 18 2019, 10:50 PM
skibo updated the diff for D22060: Fixes and updates to Zynq u-boot ports.

Remove uEnv.txt.

Oct 18 2019, 8:14 PM
skibo added inline comments to D22060: Fixes and updates to Zynq u-boot ports.
Oct 18 2019, 7:34 PM
skibo added inline comments to D22060: Fixes and updates to Zynq u-boot ports.
Oct 18 2019, 7:10 PM

Oct 16 2019

skibo created D22060: Fixes and updates to Zynq u-boot ports.
Oct 16 2019, 5:42 PM

Oct 12 2019

skibo abandoned D5512: ubldr for arm64.

Cleaning up very old stuff. We don't need ubldr on arm64.

Oct 12 2019, 6:53 PM

Oct 1 2019

skibo updated the diff for D14698: [new driver] zilinx/zy7_qspi: Add a qspi driver for Zynq platforms..

Indentation, cite updated reference manual w.r.t. transmit fifo quirk.

Oct 1 2019, 10:11 PM · ARM

Aug 26 2018

skibo updated the diff for D14698: [new driver] zilinx/zy7_qspi: Add a qspi driver for Zynq platforms..

Change driver declaration to fix a bug that caused the wrong kind of spibus to attach. Thanks, Ian Lepore.

Aug 26 2018, 9:35 PM · ARM

Aug 24 2018

skibo added a comment to D14698: [new driver] zilinx/zy7_qspi: Add a qspi driver for Zynq platforms..

I've made suggested changes but the driver has regressed: the flash device doesn't get recognized. I'm looking into it.

Aug 24 2018, 3:56 PM · ARM
skibo updated the diff for D14698: [new driver] zilinx/zy7_qspi: Add a qspi driver for Zynq platforms..

Add sys/dev/flash/mx25lreg.h which has two new flash commands added.

Aug 24 2018, 3:54 PM · ARM
skibo updated the diff for D14698: [new driver] zilinx/zy7_qspi: Add a qspi driver for Zynq platforms..

Take driver out of GENERIC kerne. Make other minor fix-ups.

Aug 24 2018, 3:50 PM · ARM

Aug 23 2018

skibo added inline comments to D14698: [new driver] zilinx/zy7_qspi: Add a qspi driver for Zynq platforms..
Aug 23 2018, 6:56 PM · ARM
skibo added inline comments to D14698: [new driver] zilinx/zy7_qspi: Add a qspi driver for Zynq platforms..
Aug 23 2018, 6:38 PM · ARM
skibo added a comment to D14698: [new driver] zilinx/zy7_qspi: Add a qspi driver for Zynq platforms..

Any chance of getting this committed before code freeze? I think it's ready. I'm not comfortable making the changes to mx25l.c to support dual stacked memories (I have no hardware to test that) but I've left in the hooks needed in this driver.

Aug 23 2018, 4:38 PM · ARM

Aug 11 2018

skibo created D16686: Add disable-wp property to sdhci_fdt.c.
Aug 11 2018, 9:06 PM

Aug 8 2018

skibo updated the diff for D14698: [new driver] zilinx/zy7_qspi: Add a qspi driver for Zynq platforms..

Add compatible string for Zynq Ultrascale which uses same qspi device.

Aug 8 2018, 9:52 PM · ARM

Apr 26 2018

skibo updated the diff for D14698: [new driver] zilinx/zy7_qspi: Add a qspi driver for Zynq platforms..

Fix support for dual parallel and stacked memories (changes provided by John Sears). Change config option from zy7_qspi to just qspi.

Apr 26 2018, 10:38 PM · ARM

Mar 31 2018

skibo updated the diff for D14698: [new driver] zilinx/zy7_qspi: Add a qspi driver for Zynq platforms..

Add license identifier. Add comment saying what this is. Move forward declaration of zy7_detach. Add MODULE_DEPEND and DRIVER_MODULE.

Mar 31 2018, 5:35 PM · ARM

Mar 30 2018

skibo added inline comments to D14698: [new driver] zilinx/zy7_qspi: Add a qspi driver for Zynq platforms..
Mar 30 2018, 7:16 PM · ARM

Mar 29 2018

skibo updated the diff for D14698: [new driver] zilinx/zy7_qspi: Add a qspi driver for Zynq platforms..

Add driver to GENERIC kernel. Add untested support for dual parallel and stacked memories.

Mar 29 2018, 8:04 PM · ARM

Mar 28 2018

skibo added a comment to D14698: [new driver] zilinx/zy7_qspi: Add a qspi driver for Zynq platforms..
In D14698#311089, @manu wrote:

Why do we still use a non-GENERIC kernel config and custom DTS for this board ?

Mar 28 2018, 10:20 PM · ARM

Mar 22 2018

br awarded D14698: [new driver] zilinx/zy7_qspi: Add a qspi driver for Zynq platforms. a Like token.
Mar 22 2018, 12:22 PM · ARM

Mar 17 2018

skibo updated the diff for D14698: [new driver] zilinx/zy7_qspi: Add a qspi driver for Zynq platforms..

Properly free resources if zy7_qspi_init_hw() fails.

Mar 17 2018, 7:52 PM · ARM
skibo added inline comments to D14698: [new driver] zilinx/zy7_qspi: Add a qspi driver for Zynq platforms..
Mar 17 2018, 6:45 PM · ARM

Mar 14 2018

skibo created D14698: [new driver] zilinx/zy7_qspi: Add a qspi driver for Zynq platforms..
Mar 14 2018, 10:05 PM · ARM

Feb 18 2018

skibo created D14429: Support single core Zynq devices (MiniZed)..
Feb 18 2018, 7:14 PM
skibo created D14428: Support for booting into kdb on arm platforms..
Feb 18 2018, 6:51 PM

Jun 9 2016

skibo added a comment to D5512: ubldr for arm64.

Is there any objection to this getting committed? This may help with the RPI3 work we're doing at BSDCan right now.

Jun 9 2016, 4:06 AM

Apr 26 2016

skibo added a comment to D6095: Fix Zynq interrupts and rearrange FDT files..

I did not know about the clock framework. I can look into migrating the Zynq stuff to it but I may not get to it in time for 11.0-RELEASE. I'd like to see this committed and treat migrating to the gnu dts as a separate project.

Apr 26 2016, 6:53 PM
skibo added a comment to D6095: Fix Zynq interrupts and rearrange FDT files..

Have you tried using the Linux dts files in sys/gnu/dts/arm? I prefer us moving towards using them over our non-standard entries.

Apr 26 2016, 3:40 PM

Apr 25 2016

skibo retitled D6095: Fix Zynq interrupts and rearrange FDT files. from to Fix Zynq interrupts and rearrange FDT files..
Apr 25 2016, 10:03 PM

Mar 10 2016

skibo added a comment to D5512: ubldr for arm64.

I noticed there was still one compilation error not resolved here, namely:

sys/boot/uboot/lib/disk.c:160:7: error: format specifies type 'int' but the argument has type 'size_t' (aka 'unsigned long') [-Werror,-Wformat]

size, SI(dev).bsize);

Changing the format specifier for 'size' from %d to %zu should make it work on all archs.

Mar 10 2016, 4:49 PM
skibo added a comment to D5512: ubldr for arm64.

If you need to load something at a specific address I would prefer it was a boot1 like tool. This would then load ubldr from UFS and branch to it.

Alternatively, what's wrong with loading the .bin file & running it with go?

Mar 10 2016, 4:05 PM
skibo added a comment to D5512: ubldr for arm64.

Yes you can always just run the .bin file. Just wanted to point out that the '-pie' version will possibly never work with U-Boot, while the non-pie version would be nice to keep as it is confirmed to be working. I remember when I tested the initial patches by Thomas (version from the mailing list) on my ARM64 board I could not get the .bin version to work - it got to the prompt but loading the kernel via network hanged indefinitely. The ELF version , however, loaded and booted the kernel.

Mar 10 2016, 3:57 PM

Mar 9 2016

skibo updated the diff for D5512: ubldr for arm64.

Missed a clean file.

Mar 9 2016, 9:23 PM
skibo updated the diff for D5512: ubldr for arm64.

Bring back position dependent ubldr.

Mar 9 2016, 9:18 PM
skibo added a comment to D5512: ubldr for arm64.

Would it be possible to leave the position-dependent targets in the makefile as it was on arm32? The '-pie' version is rejected by U-Boot when bootelf is run, as it only recognizes ELFs with e_type == ET_EXEC. So in this version only the .bin is usable with U-Boot.

Mar 9 2016, 7:45 PM

Mar 7 2016

skibo updated the diff for D5512: ubldr for arm64.

Add comment in ldscript.aarch64 explaining text section alignment.

Mar 7 2016, 6:19 PM

Mar 6 2016

skibo added inline comments to D5512: ubldr for arm64.
Mar 6 2016, 7:14 PM

Mar 4 2016

skibo updated the diff for D5512: ubldr for arm64.

Get relocation to work. Remove static linked target.

Mar 4 2016, 3:46 PM
skibo added inline comments to D5512: ubldr for arm64.
Mar 4 2016, 3:34 PM
skibo added inline comments to D5512: ubldr for arm64.
Mar 4 2016, 12:32 AM

Mar 3 2016

skibo added inline comments to D5512: ubldr for arm64.
Mar 3 2016, 9:09 PM
skibo added inline comments to D5512: ubldr for arm64.
Mar 3 2016, 3:10 PM
skibo added inline comments to D5512: ubldr for arm64.
Mar 3 2016, 3:06 PM
skibo updated the diff for D5512: ubldr for arm64.

Don't adjust va->pa offset in EFI loader. Clean up assembly in start.S.

Mar 3 2016, 2:57 PM

Mar 2 2016

skibo added inline comments to D5512: ubldr for arm64.
Mar 2 2016, 7:28 PM

Mar 1 2016

skibo retitled D5512: ubldr for arm64 from to ubldr for arm64.
Mar 1 2016, 8:24 PM