Differential D22060

Fixes and updates to Zynq u-boot ports
AbandonedPublic
Actions

Authored by skibo on Oct 16 2019, 5:42 PM.

Details

Reviewers

manu

Summary

Fix build breakage in recent u-boot releases. Update uEnv.txt files. Fix package description of u-boot-zybo.

Test Plan

Tested on Zybo.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

skibo created this revision.Oct 16 2019, 5:42 PM

Herald added subscribers: Contributor Reviewers (ports), mat. · View Herald TranscriptOct 16 2019, 5:42 PM

manu added a subscriber: manu.Oct 18 2019, 11:24 AM

manu added inline comments.

sysutils/u-boot-zedboard/files/uEnv.txt
0	I'm pretty sure that uEnv.txt isn't parsed anymore, if that is the case we should just drop it.

manu added a reviewer: manu.Oct 18 2019, 11:25 AM

skibo added inline comments.Oct 18 2019, 7:10 PM

sysutils/u-boot-zedboard/files/uEnv.txt
0	It won't boot without this so it is parsed. Looks like this is board-specific (see include/configs/zynq-common.h). But, I had the idea that there might be a default filename for the dtb like system.dtb and maybe I can get rid of this. I'll check into this...

skibo added inline comments.Oct 18 2019, 7:34 PM

sysutils/u-boot-zedboard/files/uEnv.txt
0	There is a default dtb filename. It's "zynq-zynq.dtb" in Zybo's case (weird) so I don't need uEnv.txt. Also, the script I use to make an image generates uEnv.txt anyway so it doesn't need to be here. I'll upload a diff without uEnv.txt and adjust the Makefile so it's not installed.

Remove uEnv.txt.

Also, u-boot-master/Makefile creates a boot.scr for all arm boards but the zynq boards ignore it and don't need it. Should we come up with an exception for zynq boards?

This diff is no longer valid because the Zynq u-boot ports have been removed.

This is pity that this patch get abandoned. If this patch fixes the issue, we can certainly readd these ports. @skibo and @manu , are you still interested in checking this?

In D22060#508475, @lwhsu wrote:

This is pity that this patch get abandoned. If this patch fixes the issue, we can certainly readd these ports. @skibo and @manu , are you still interested in checking this?

I don't mind adding those ports again if they work, Milan Obuch on u-boot@ said that the zybo ports needs a patch. I want this patch submitted properly upstream before doing anything here as I don't want to maintain patch in the ports tree for u-boot (especially when I don't have the hardware).

I'll look into submitting the fix to u-boot but it won't appear until 2020.04.