Page MenuHomeFreeBSD

kbowling (Kevin Bowling)
User

Projects

User Details

User Since
Jun 6 2015, 10:46 PM (540 w, 2 d)

Recent Activity

Today

kbowling added a comment to D53105: tcp: debugging checks of hashing.

I think this would be useful for driver developers, but we'd need to document is suitably so people know to look for it.

Tue, Oct 14, 8:49 PM
kbowling accepted D53104: tcp: Enable symmetric hashing by setting hash on outgoing conns.
Tue, Oct 14, 8:48 PM
kbowling accepted D53093: ixgbe: Use newly exposed RSS hash API rather than ad-hoc hashing.
Tue, Oct 14, 8:47 PM
kbowling accepted D53097: e1000: use newly exposed RSS hash key API rather than ad-hoc hashing.
Tue, Oct 14, 8:46 PM

Wed, Oct 8

kbowling accepted D52549: ixl(4): fix multicast promiscuous mode state tracking and filter management.

Looks good thanks for chasing it down

Wed, Oct 8, 6:08 PM
kbowling accepted D52976: igb(4): Fix out-of-bounds register access on VFs.
Wed, Oct 8, 5:06 PM

Sat, Oct 4

kbowling accepted D52913: ice.4: Improve SYNOPSIS.

The deletions seem fine. The convention is probably up to you if you are changing to this.

Sat, Oct 4, 11:53 PM
kbowling accepted D52831: x11/nvidia-driver[-devel], x11/linux-nvidia-libs[-devel], graphics/nvidia-drm*-kmod[-devel], x11/nvidia-settings, x11/nvidia-xconfig: Update to 580.95.05.

Holding until Tuesday on this, FreeBSD-ports-kmods still isn't receiving pkgs for nvidia-kmod and @bapt needs some time before looking at it.

Sat, Oct 4, 9:47 PM

Wed, Oct 1

kbowling accepted D52782: ice(4): Add PCI IDs for E835 devices.
Wed, Oct 1, 6:16 AM

Sat, Sep 27

kbowling accepted D52178: x11/nvidia-driver: Splitting out kmod part of x11/nvidia-driver into x11/nvidia-kmod, including slave ports..
Sat, Sep 27, 2:33 AM

Sep 12 2025

kbowling created P671 etcupdate -B.
Sep 12 2025, 7:03 AM

Sep 10 2025

kbowling accepted D52464: rmuser.sh: Improve prompt consistency with adduser.
Sep 10 2025, 10:14 PM
kbowling accepted D52467: ix(4): Remove unused function ixgbe_is_media_cage_present.
Sep 10 2025, 7:24 AM

Sep 9 2025

kbowling accepted D52442: ix(4): Fix incomplete speed coverage in link status logging.
Sep 9 2025, 4:59 PM

Sep 8 2025

kbowling accepted D52376: qlnxe: Report decimal format for speeds.
Sep 8 2025, 7:38 PM
kbowling accepted D52375: qlnxe: Support SIOCGIFXMEDIA ioctl.
Sep 8 2025, 7:37 PM
kbowling accepted D52374: qlnxe: Unconditionally enable extended media types.
Sep 8 2025, 7:36 PM
kbowling accepted D52369: iflib: report output drops and handle ENOBUFS properly.
Sep 8 2025, 7:35 PM

Sep 5 2025

kbowling added a comment to D52390: e1000: remove unused header file.

There are two possible concerns that come to mind:

Sep 5 2025, 12:07 AM

Sep 4 2025

kbowling accepted D52326: first cut at reading igb vf stat support.
Sep 4 2025, 11:38 PM

Sep 3 2025

kbowling accepted D52352: x11/nvidia-driver[-devel], x11/linux-nvidia-libs[-devel], graphics/nvidia-drm*-kmod[-devel], x11/nvidia-settings, x11/nvidia-xconfig: Update to 580.82.07.
Sep 3 2025, 9:08 AM

Sep 2 2025

kbowling added inline comments to D52326: first cut at reading igb vf stat support.
Sep 2 2025, 6:05 PM

Sep 1 2025

kbowling added a comment to D52326: first cut at reading igb vf stat support.

overall looks fine

Sep 1 2025, 11:06 PM

Aug 27 2025

kbowling accepted D50712: iflib: Set the get counter routine prior to attaching the interface.
Aug 27 2025, 3:52 AM

Aug 26 2025

kbowling added a comment to D50712: iflib: Set the get counter routine prior to attaching the interface.

@zlei do you know if all the consumer ifdi_get_counter implementations will still have been initialized correctly, for instance not making invalid references? It seems fine as long as there are no implicit initialization issues that relied on the current behavior.

Aug 26 2025, 5:21 PM
kbowling accepted D50713: iflib: Make iflib_register() return void.
Aug 26 2025, 4:12 PM

Aug 19 2025

kbowling closed D51941: x11/nvidia-driver[-devel], x11/linux-nvidia-libs[-devel], graphics/nvidia-drm*-kmod[-devel], x11/nvidia-settings, x11/nvidia-xconfig: Update to 580.76.05.

Committed in 9dbf8452e1fbb8e075b0f8d978fe9be9d0df9355

Aug 19 2025, 7:10 PM
kbowling added a comment to D50067: ix/ixv: Add support for new Intel Ethernet E610 family devices.

Fixing Eric's comment about codename seemed as a trivial change so I tried to do it without engaging Yogesh and updating the review. I'm sorry, it looks like it was a poor idea. Commit wasn't automatically detected by Phabricator and this review is still open. Is there anything else I should do except for adding the commit with 'Edit Related Objects', and promising to not try to cut the corners in the future?

Aug 19 2025, 6:48 PM

Aug 18 2025

kbowling accepted D51905: iflib: add a simple transmit routine.

LGTM, it's out of the way aside from a branch and the change to iflib_encap (is this change strictly necessary for simple or can it be committed separately?).

Aug 18 2025, 10:55 PM

Aug 17 2025

kbowling accepted D51941: x11/nvidia-driver[-devel], x11/linux-nvidia-libs[-devel], graphics/nvidia-drm*-kmod[-devel], x11/nvidia-settings, x11/nvidia-xconfig: Update to 580.76.05.
Aug 17 2025, 3:01 AM

Aug 15 2025

kbowling added a reviewer for D51905: iflib: add a simple transmit routine: kgalazka.
Aug 15 2025, 6:25 AM

Aug 13 2025

kbowling accepted D51888: x11/nvidia-driver-304, x11/nvidia-driver-340 Fix build after commit 9302fb05a0c6.
Aug 13 2025, 5:12 PM

Aug 9 2025

kbowling closed D7986: Simplify cubic_ack_received.

@imp if I recall this was something we were looking at on my team at LLNW, if it were in Bugzilla I'd say "Close - OBE" is appropriate.

Aug 9 2025, 7:24 PM · srcmgr

Aug 8 2025

kbowling accepted D51772: iflib: simplify lro & use lro_queue_mbuf().
Aug 8 2025, 9:13 PM

Aug 6 2025

kbowling accepted D51780: x11/nvidia-driver, x11/linux-nvidia-libs, graphics/nvidia-drm*-kmod, x11/nvidia-settings, x11/nvidia-xconfig: Update to 570.181.
Aug 6 2025, 11:58 PM

Aug 5 2025

kbowling accepted D51748: iflib: don't pullup UDP payloads to the TCP header size.
Aug 5 2025, 8:06 PM

Aug 4 2025

kbowling added inline comments to D50934: ix(4): Add support for debug dump for E610 adapters.
Aug 4 2025, 5:40 AM

Aug 2 2025

kbowling accepted D50934: ix(4): Add support for debug dump for E610 adapters.

@kgalazka Nothing jumping out to me here for feedback on the code. I don't have an E610 so I can't do anything with this.. it looks like this is maybe a support tool where the file is sent to Intel for assistance, but if we can embellish anything as to how an end user might use any of this on their own that would be a worthwhile followup.

Aug 2 2025, 8:05 AM
kbowling accepted D50067: ix/ixv: Add support for new Intel Ethernet E610 family devices.

@kgalazka I'm ok with this, go ahead. Please think about budgeting some time for tinderbox, lint, and early user feedback issues that may come up, and by extension when you want to send it in, i.e. a Monday would be good.

Aug 2 2025, 7:58 AM

Jul 31 2025

kbowling accepted D51644: loader: add nvidia modules to the loader blacklist.

'nvidia-drm' would also be belong in this list

Jul 31 2025, 2:28 AM

Jul 27 2025

kbowling added a comment to D50388: src.opts.mk: Default LLVM_ASSERTIONS off.

@kevans were you able to get any reaction from portmgr@?

No, sorry, I haven't had a chance to draft anything yet; I thought I had dropped a 'go ahead and do this, I will follow up on the cluster side' comment, but clearly not- sorry.

Jul 27 2025, 1:04 AM
kbowling added a comment to D50388: src.opts.mk: Default LLVM_ASSERTIONS off.

@kevans were you able to get any reaction from portmgr@?

Jul 27 2025, 12:43 AM

Jul 25 2025

kbowling added a comment to D51547: getsockopt.2: Add SO_SPLICE source socket read and socket close behavior.

@markj I think this behavior is identical to OpenBSD so adding part of their man doc.

Jul 25 2025, 11:02 PM
kbowling requested review of D51547: getsockopt.2: Add SO_SPLICE source socket read and socket close behavior.
Jul 25 2025, 10:58 PM

Jul 24 2025

kbowling accepted D51484: x11/nvidia-driver-devel, x11/linux-nvidia-libs-devel, graphics/nvidia-drm-*-kmod-devel: Update to 575.64.05.
Jul 24 2025, 9:06 PM

Jul 22 2025

kbowling accepted D51451: qlnxe: Advertise the IFCAP_HWSTATS capability.

I would remove the phrase 'change will not fix anything but' in the commit message and I think this is good.

Jul 22 2025, 3:28 AM

Jul 21 2025

kbowling added a comment to D51451: qlnxe: Advertise the IFCAP_HWSTATS capability.

In the commit message do you mean to say there is something else double counting?

Jul 21 2025, 11:22 AM
kbowling accepted D51450: qlnxe: Fix advertising the IFCAP_LINKSTATE capability.
Jul 21 2025, 11:21 AM

Jul 18 2025

kbowling accepted D51407: x11/nvidia-driver, x11/linux-nvidia-libs, graphics/nvidia-drm-*-kmod: Update to 570.172.08.
Jul 18 2025, 7:10 PM

Jul 17 2025

kbowling closed D51340: x11/nvidia-driver: Fix build after src main 4dd828c80828637452a8a4e07a64e294c82e5d8b.

Pushed as 9302fb05a0c6599bbe8963ff5201fd3b99994535

Jul 17 2025, 2:27 AM
kbowling accepted D51340: x11/nvidia-driver: Fix build after src main 4dd828c80828637452a8a4e07a64e294c82e5d8b.

Although I suppose the existing change is fine and maybe preferable

Jul 17 2025, 12:12 AM
kbowling requested changes to D51340: x11/nvidia-driver: Fix build after src main 4dd828c80828637452a8a4e07a64e294c82e5d8b.

1500052 was just allocated for this in ff2dc0bca372

Jul 17 2025, 12:11 AM

Jul 16 2025

kbowling accepted D51351: qlnxe: Fix SIOCGI2C ioctl.
Jul 16 2025, 10:28 PM
kbowling accepted D51295: qlnxe: Fix build with INET.
Jul 16 2025, 10:26 PM
kbowling accepted D51340: x11/nvidia-driver: Fix build after src main 4dd828c80828637452a8a4e07a64e294c82e5d8b.
Jul 16 2025, 4:26 PM

Jul 15 2025

kbowling accepted D51331: ixl(4): Fix queue MSI and legacy IRQ rearming.
Jul 15 2025, 6:25 PM

Jul 4 2025

kbowling accepted D51144: x11/nvidia-driver-devel, x11/linux-nvidia-libs-devel, graphics/nvidia-drm[,510,515,61,66]-kmod-devel: Update to 575.64.03.
Jul 4 2025, 4:16 AM

Jun 26 2025

kbowling accepted D51062: release: Fix dvdrom building dependency.
Jun 26 2025, 6:28 PM

Jun 18 2025

kbowling accepted D50915: x11/nvidia-driver, x11/linux-nvidia-libs, graphics/nvidia-drm*-kmod, x11/nvidia-settings, x11/nvidia-xconfig: Update to 570.169.
Jun 18 2025, 4:50 PM

Jun 14 2025

kbowling accepted D50654: mlx.4: Improve HARDWARE.
Jun 14 2025, 8:22 PM

Jun 13 2025

kbowling accepted D50834: src.conf.5: Update references to obsolete diag options.
Jun 13 2025, 5:38 PM

Jun 9 2025

kbowling accepted D50697: [NEW PORT] x11/nvidia-driver-devel, x11/linux-nvidia-libs-devel, graphics/nvidia-drm[,510,515,61,66]-kmod-devel: Add new port.
Jun 9 2025, 10:34 PM

Jun 8 2025

kbowling accepted D50744: Add missing MOVED entries for x11/nvidia-secondary-driver[-390].
Jun 8 2025, 7:46 PM

May 30 2025

kbowling added a comment to D50067: ix/ixv: Add support for new Intel Ethernet E610 family devices.

Generally ok with this. I would like to know if the malloc thing can be addressed during init or if that is required by your upcoming changes.

May 30 2025, 12:28 PM
kbowling added a comment to D50388: src.opts.mk: Default LLVM_ASSERTIONS off.

I'm planning to commit this soon unless a serious objection is raised.

May 30 2025, 12:24 PM

May 28 2025

kbowling accepted D50548: igc: Fix some issues in igc_neweitr().
May 28 2025, 8:26 AM
kbowling accepted D50547: igc: Initialize helper variables in igc_neweitr().
May 28 2025, 8:26 AM
kbowling accepted D50327: ice(4): Update E830-XXV device ids.
May 28 2025, 4:31 AM

May 25 2025

kbowling accepted D49906: lang/go: Provide only one go version.
May 25 2025, 4:39 AM

May 24 2025

kbowling added a comment to D49906: lang/go: Provide only one go version.

Is there a way to vendor the alt toolchains? It is imperative this doesn't start downloading from the internet outside of the fetch step, the same standards things like Cargo, Maven, etc have in ports. As long as that is addressed I think the overall concept is fine now -- it will be awkward if we have to patch Go but hopefully that is not common.

May 24 2025, 10:35 PM

May 23 2025

kbowling accepted D50502: x11/nvidia-xconfig: Update to 570.153.02 to keep sync with x11/nvidia-driver.
May 23 2025, 11:31 PM
kbowling accepted D50501: x11/nvidia-settings: Update to 570.153.02 to keep sync with x11/nvidia-driver.
May 23 2025, 11:30 PM
kbowling accepted D50487: Update x11/nvidia-driver, x11/linux-nvidia-libs, graphics/nvidia-drm-*-kmod to 570.153.02.
May 23 2025, 7:57 PM

May 20 2025

kbowling accepted D50416: e1000: Fix races in the AIM implementation.

@markj go ahead and commit the initialization and style changes. I need a moment to think about the threading, so I would ask that goes in a separate commit, which you are free to do as well. Is there any reason not to use _int variant over long? This should MFC back to 32 bit platforms which seem to generate different code vs x86 for whatever it's worth. The driver is also "upstream" for RTEMS and other smaller systems.

May 20 2025, 3:27 PM
kbowling added inline comments to D50416: e1000: Fix races in the AIM implementation.
May 20 2025, 4:07 AM
kbowling added inline comments to D50416: e1000: Fix races in the AIM implementation.
May 20 2025, 2:00 AM

May 17 2025

kbowling added a comment to D50388: src.opts.mk: Default LLVM_ASSERTIONS off.

Or, like WITNESS or MALLOC_PRODUCTION, on in HEAD and off in stable branches?

May 17 2025, 2:18 AM
kbowling added inline comments to D50067: ix/ixv: Add support for new Intel Ethernet E610 family devices.
May 17 2025, 12:18 AM
kbowling requested review of D50388: src.opts.mk: Default LLVM_ASSERTIONS off.
May 17 2025, 12:14 AM

May 16 2025

kbowling added a comment to D50128: ixgbe: add MDIO bus support.

I would be somewhat curious why we need to serialize like this. Note that nothing else prodding the swfw in ixgbe is explicitly locked or asserted.

I was thinking about ixgbe_if_init and ixgbe_config_link. IIRC under the hood it does couple of MDIO reads and writes. The SWFW semaphore is hold for individual accesses, but not during whole operation. Without CTX lock writes from mdio bus may interfere with that and bringing link up may fail.

May 16 2025, 9:22 PM
kbowling added inline comments to D50067: ix/ixv: Add support for new Intel Ethernet E610 family devices.
May 16 2025, 8:54 PM
kbowling requested changes to D50067: ix/ixv: Add support for new Intel Ethernet E610 family devices.

Please reupload with context (git diff -U9999). It also seems to not be based on FreeBSD main.

May 16 2025, 8:25 PM

May 14 2025

kbowling added a comment to D50067: ix/ixv: Add support for new Intel Ethernet E610 family devices.

To add to what @erj said, multi-arch build is a requirement the same as on other OS projects. We have to provide some advance notice to drop things and this should be MFC'd back to 13 and 14. See build(7), 'make universe' or 'make kernels' is enough. I don't see anything off hand that is problematic, and there is no expectation on Intel for validation for odd platforms. But it has to build everywhere it currently does.

May 14 2025, 8:28 PM
kbowling accepted D50327: ice(4): Update E830-XXV device ids.
May 14 2025, 10:01 AM
kbowling accepted D48812: ppt: Fix panic when configuring unavailable MSI-X vector.
May 14 2025, 6:30 AM
kbowling accepted D50332: committers-src: add myself (kgalazka@).
May 14 2025, 6:27 AM

May 12 2025

kbowling added a comment to D50282: graphics/nvidia-drm-kmod: Make distinfo auto-merged on build.

I do see the improvement here for the drm maintainers not having to deal with all this, but I'd like someone with more ports infra experience to evaluate the implementation.

May 12 2025, 8:39 AM
kbowling added a comment to D50295: ixgbe: improve MDIO performance by reducing semaphore/IPC delays.

The first change seems sensible.

May 12 2025, 4:49 AM

May 11 2025

kbowling accepted D50142: x11/nvidia-driver, x11/linux-nvidia-libs: Split and distribute distinfo per-slave-ports.

I'm generally fine with what is here, it seems logical to me.

May 11 2025, 11:19 PM

May 10 2025

kbowling added a comment to D50128: ixgbe: add MDIO bus support.

I would be somewhat curious why we need to serialize like this. Note that nothing else prodding the swfw in ixgbe is explicitly locked or asserted.

May 10 2025, 4:52 AM
kbowling added inline comments to D50128: ixgbe: add MDIO bus support.
May 10 2025, 2:20 AM

May 9 2025

kbowling updated the diff for D50265: net-p2p/bitcoin*: Update to 29.0.

Fix DBUS, reported as https://github.com/bitcoin/bitcoin/issues/32464

May 9 2025, 9:06 PM
kbowling updated the diff for D50265: net-p2p/bitcoin*: Update to 29.0.
May 9 2025, 7:12 PM
kbowling added inline comments to D50265: net-p2p/bitcoin*: Update to 29.0.
May 9 2025, 10:20 AM
kbowling added inline comments to D50265: net-p2p/bitcoin*: Update to 29.0.
May 9 2025, 10:19 AM
kbowling requested review of D50265: net-p2p/bitcoin*: Update to 29.0.
May 9 2025, 10:16 AM

May 7 2025

kbowling added a comment to D50243: Add new src committer information for kgalazka.

Looks good

May 7 2025, 10:13 PM
kbowling added a comment to D50243: Add new src committer information for kgalazka.

See the actual commit message from that https://reviews.freebsd.org/R9:a52de44df1a6534adec66174ee68d03444738907

May 7 2025, 7:05 PM
kbowling added a comment to D50243: Add new src committer information for kgalazka.

It will be helpful, especially early on, to add a fully formatted commit message to the review description so we can have a look and make sure you have the git config right.

May 7 2025, 6:01 PM
kbowling accepted D50243: Add new src committer information for kgalazka.
May 7 2025, 6:00 PM