Page MenuHomeFreeBSD
Differential D50265

net-p2p/bitcoin*: Update to 29.0
ClosedPublic
Actions

Authored by kbowling on Fri, May 9, 10:16 AM.
Tags
None
Referenced Files
F117023531: D50265.id155238.diff
Tue, May 13, 7:37 AM
F116969713: D50265.id.diff
Mon, May 12, 3:53 PM
F116968452: D50265.diff
Mon, May 12, 3:27 PM
Unknown Object (File)
Mon, May 12, 12:05 PM
Unknown Object (File)
Mon, May 12, 11:47 AM
Unknown Object (File)
Mon, May 12, 9:05 AM
Unknown Object (File)
Sat, May 10, 8:27 AM
Subscribers
None

Details

Reviewers
diizzy
jhale
arrowd
makc
Commits
R11:1813f80d0043: net-p2p/bitcoin[-daemon,-utils]: Update to 29.0
Summary

The build has moved to cmake so looking for some extra feedback before pushing this

https://raw.githubusercontent.com/bitcoin/bitcoin/refs/heads/29.x/CMakeLists.txt

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kbowling requested review of this revision.Fri, May 9, 10:16 AM
kbowling created this revision.
kbowling added inline comments.Fri, May 9, 10:19 AM
net-p2p/bitcoin-utils/Makefile
19

This and the man page need to move to WALLET_PLIST_FILES+=

kbowling added inline comments.Fri, May 9, 10:20 AM
net-p2p/bitcoin/Makefile
97–98

this should be deleted

arrowd added inline comments.Fri, May 9, 5:56 PM
net-p2p/bitcoin-daemon/Makefile
10

A good style is to first list enabled options and then disabled.

net-p2p/bitcoin/Makefile
63

You can use TESTS_CMAKE_BOOL here as well.

kbowling updated this revision to Diff 155216.Fri, May 9, 7:12 PM
kbowling marked 2 inline comments as done.
kbowling updated this revision to Diff 155226.Fri, May 9, 9:06 PM

Fix DBUS, reported as https://github.com/bitcoin/bitcoin/issues/32464

This revision was not accepted when it landed; it landed in state Needs Review.Sat, May 10, 8:01 AM
Closed by commit R11:1813f80d0043: net-p2p/bitcoin[-daemon,-utils]: Update to 29.0 (authored by Kevin Bowling <kbowling@FreeBSD.org>). · Explain Why
This revision was automatically updated to reflect the committed changes.
Kevin Bowling <kbowling@FreeBSD.org> added a commit: R11:1813f80d0043: net-p2p/bitcoin[-daemon,-utils]: Update to 29.0.

Revision Contents
Changeset List

PathSize
21 lines
net-p2p/
bitcoin-daemon/
29 lines
bitcoin-utils/
32 lines
bitcoin/
107 lines
6 lines
files/
11 lines

Diff 155238

View Options

UPDATING

Loading...
View Options

net-p2p/bitcoin-daemon/Makefile

Loading...
View Options

net-p2p/bitcoin-utils/Makefile

Loading...
View Options

net-p2p/bitcoin/Makefile

Loading...
View Options

net-p2p/bitcoin/distinfo

Loading...
View Options

net-p2p/bitcoin/files/patch-CMakeLists.txt

Loading...
View Options

net-p2p/bitcoin/files/patch-src_qt_trafficgraphwidget.h

Loading...