Page MenuHomeFreeBSD

x11/nvidia-driver: Fix build after src main 4dd828c80828637452a8a4e07a64e294c82e5d8b
ClosedPublic

Authored by junchoon_dec.sakura.ne.jp on Jul 16 2025, 9:28 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Sep 12, 3:30 AM
Unknown Object (File)
Thu, Sep 11, 6:00 AM
Unknown Object (File)
Sep 9 2025, 8:01 PM
Unknown Object (File)
Sep 5 2025, 2:05 PM
Unknown Object (File)
Aug 31 2025, 9:03 PM
Unknown Object (File)
Aug 31 2025, 4:37 PM
Unknown Object (File)
Jul 28 2025, 10:59 PM
Unknown Object (File)
Jul 28 2025, 9:24 PM
Subscribers
None

Details

Reviewers
kbowling
ashafer
kib
Group Reviewers
x11
Summary

Commit 4dd828c80828637452a8a4e07a64e294c82e5d8b on main branch of src removed 2 macros, DMAP_MIN_ADDRESS and DMAP_MAX_ADDRESS and require to use variables (members of struct) kva_layout.dmap_low and kva_layout.dmap_high respectively.

This broke builds of x11/nvidia-driver[-304|-340|-390|-470|-devel].
And the change is not planned for MFC (POLA violation).

Fix build by using new variables conditionally.

As there are around 10 days between usable latest bump at base 65ed1a035ceb8f7c323c0bc0c7344a7fa7cadc9f and base 4dd828c80828637452a8a4e07a64e294c82e5d8b, there are broken time window.

PR: 288236

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

This is probably fine, but isn't it better to provide the real patch instead of running sed?

This revision is now accepted and ready to land.Jul 16 2025, 9:38 AM

Thanks!
Using sed is not to worry when upstream (nvidia) incorporates fix in the future.

1500052 was just allocated for this in ff2dc0bca372

This revision now requires changes to proceed.Jul 17 2025, 12:10 AM

Although I suppose the existing change is fine and maybe preferable

This revision is now accepted and ready to land.Jul 17 2025, 12:12 AM