Slightly cleaner would be to use a local variable for msg_len, and write it out at the end, but this is fine.

Address feedback from @ziaee.

Ping? Been a couple months, want to wrap it all up.

Split into D49182 and D49183

In D48633#1114612, @olce wrote:

In D48633#1114603, @jhibbits wrote:

I don't think it's possible to have domain 0 unpopulated on powerpc. I do have a patch that implements the NUMAing of mmu_radix_page_array_startup(), but it didn't improve performance any measurable degree when I tested, so never followed through with pushing it.

I see. I've taken care of updating the code under #ifdef notyet as a future reference, just in case.

Can I change the argument to -1 here? This will in practice change nothing as long as domain 0 is populated and not too small.

I don't think it's possible to have domain 0 unpopulated on powerpc. I do have a patch that implements the NUMAing of mmu_radix_page_array_startup(), but it didn't improve performance any measurable degree when I tested, so never followed through with pushing it.

In D47312#1110694, @jhb wrote:

So if I'm reading this correctly, there are a couple of changes here that aren't quite described in the commit log:

1. In the existing interface, the "pat" operation (both ioctl and in-kernel) accepts a mask of a control operation and a timeout value. In the new interface, the pat interface only accepts the timeout and a new control operation handles things like resetting the watchdog. I actually think just splitting that change out into its own commit (i.e. adding the new function and ioctl) earlier in the series might be nicer (if it is indeed separable).

Ping, anyone?

Abandoned in favor of D48064.

LGTM

Actually update the date...

In D47931#1092874, @concussious.bugzilla_runbox.com wrote:

This is cool! Just a few tiny nits from me. emaste is correct about the empty space, it actually produces two linter errors.

Update date.

Address feedback. Also ran mandoc -T lint over it, and fixed existing lint errors.

Taken care of with c78ebc69 and 797f1c7c

In D47685#1087555, @imp wrote:

Might be worth publishing the noise count as a per-dev sysctl

Closed by 09ef5387

Should this also be applied to stand/powerpc/boot1.chrp/bootinfo.txt?

In D47525#1083994, @emaste wrote:

As an aside, are ifapi man pages coming soon?

$ apropos ifapi
apropos: nothing appropriate
$ apropos if_getlladdr
apropos: nothing appropriate

Thanks!

Ping, anyone?

In D47358#1080093, @emaste wrote:

Really cool work. I think this could use a better description though (and possibly a rename) - in current usage the rescue prefix suggests rescue(8) and it's not clear to me what a "direct dumper" is. The summary message should include a brief description of what this actually is.