Refreshed patch. @ashish any feedback on this?

Reverted the replacement of static release tarball with USE_GITHUB.

Wrong commit order, accidentally deleted license.

Fixed style(9) issues.

That makes sense, I will continue working on an actual solution to the panic. Thanks for the clarification.

Fix style and semantics issues

Thanks for the feedback Kostik! Updated to reflect the changes.

Accidentally had extra whitespace in previous diff

• Moved around kernel options to correct locations and added additional comments
• Added assert for checking bounds of array access

Add license after consulting with Ed

• Add a check for the maximum history size. This maximum is set to the same value as the maximum in syscons(4).
• Fix the error string on a negative number argument

Accidentally updated wrong review, reverting back to previous diff

• Add a check for the maximum history size. This maximum is set to the same value as the maximum in syscons(4).
• Fix the error string on a negative number argument

cngets() already calls cngrab() in sys/kern/kern_cons.c here:

Fixed style issues.

• Added comment to sys/kern/capabilities.conf for more information on where the sysents are being initialized
• Added flags to SYSCALL32 initializers

Changed module syscall init helpers to initialize flags

Shouldn't expose locking macros to makefs

Abandoning because this change doesn't functionally change anything, it isn't actually fixing any bugs.

Reverted DEEXTERNALIZE changes, refer to D11217 for bugfix

Removed style change, added comment for #ifdef

Changed #ifndef MAKEFS to #ifdef _KERNEL.

Rebased with master

How did you produce this bug? I am not able to reproduce it on my end.

Ah you're right, I think I must have included a few extra commits in the diff, I'll fix this diff and make it relative to master.

Renamed buf and vnode fields to match NetBSD

What is the best course of action then? Are these whitespace changes ok or should we ignore this and continue with D10803?

• Removed whitespace and style changes on lines other than the ones affected in this diff
• Kept u_long, u_char, etc. as is

Changed i_vnode to i_devvp to maintain consistency with NetBSD

You are referring to https://svnweb.freebsd.org/base?view=revision&revision=317967 right? Was the breaking error something like: "makefs: bread: lseek 48 (-4393751551952): Invalid argument"? My bug fixes in this diff should fix the previously breaking revision. Specifically, the problem had to do with incorrectly casting a void * field in the vnode struct as fsinfo_t. Instead, this diff adds the v_fsinfo field to the struct vnode.

Review is outdated, will be uploading independent reviews for whitespace changes and the bread bug fix. See https://reviews.freebsd.org/D10650.

Ed and I were discussing how to proceed with these changes. Instead of this review, I will post reviews for each individual feature change in makefs so it will be easier to manage. I haven't run the other tests that depend on makefs yet, I will do that before posting the other reviews. Can I abandon this revision? I will post the other reviews soon.