Page MenuHomeFreeBSD

makefs: clean up warnings, fix style, bring changes over from NetBSD
AbandonedPublic

Authored by siva on May 17 2017, 7:49 PM.
Tags
None
Referenced Files
F168805322: D10777.diff
Sun, Aug 30, 6:09 AM
F168772463: D10777.id28481.diff
Sun, Aug 30, 2:06 AM
F168766258: D10777.id.diff
Sun, Aug 30, 1:19 AM
Unknown Object (File)
Thu, Aug 27, 1:40 AM
Unknown Object (File)
Wed, Aug 26, 11:32 PM
Unknown Object (File)
Wed, Aug 26, 9:42 PM
Unknown Object (File)
Wed, Aug 26, 9:24 PM
Unknown Object (File)
Thu, Aug 13, 6:35 PM
Subscribers
None

Details

Reviewers
emaste
ngie
Summary

Submitted by emaste:

  • Whitespace fixes
  • Remove all warnings and set WARNS=6
  • Make buf generic (origin NetBSD)
    • ffs.c: 1.58
    • ffs/buf.c: 1.18
    • ffs/buf.h: 1.8
  • Comment out increment of blkno in getblk() (origin NetBSD)
    • ffs/buf.c: 1.14

Submitted by smahadevan:

  • fixed bug with bread getting wrong offset and sectorsize (origin NetBSD):
    • ffs.c: 1.59
    • ffs/buf.c: 1.19
    • ffs/buf.h: 1.9
    • ffs/ffs_alloc.c: 1.23
    • ffs/ffs_balloc.c: 1.17
    • ffs/ufs_inode.h: 1.5
    • makefs.h: 1.32
Test Plan

No functionality changes, reran makefs and fstyp tests.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Review is outdated, will be uploading independent reviews for whitespace changes and the bread bug fix. See https://reviews.freebsd.org/D10650.