makefs: add -O (offset) option
ClosedPublic
Actions

Authored by guest-svmhdvn on May 17 2017, 9:48 PM.

Details

Reviewers

emaste
ngie

Commits

rS318951: makefs: add -O (offset) option

Summary

submitted by: emaste

ffs.c 1.60
makefs.8 1.44
makefs.c 1.48
makefs.h 1.33
ffs/buf.c 1.20
ffs/mkfs.c 1.27

Obtained from: NetBSD
Relnotes: Yes

Test Plan

Manually tested. Wrote n bytes to a file, provided offset of n, used hexdump to check if original bytes still existed. Will add tests to suite soon.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

guest-svmhdvn created this revision.May 17 2017, 9:48 PM

guest-svmhdvn added a parent revision: D10777: makefs: clean up warnings, fix style, bring changes over from NetBSD.

guest-svmhdvn added reviewers: emaste, ngie.

guest-svmhdvn updated this revision to Diff 28528.May 18 2017, 5:48 PM

guest-svmhdvn edited parent revisions, added: D10803: makefs: make buf generic; removed: D10777: makefs: clean up warnings, fix style, bring changes over from NetBSD.May 18 2017, 6:01 PM

Seems to be a bug in here:

% makefs -t ffs -O 1024 foo /etc
Calculated size of `foo': 233024 bytes, 423 inodes
Extent size set to 8192
foo: 2.3MB (4752 sectors) block size 8192, fragment size 1024
       using 1 cylinder groups of 2.32MB, 297 blks, 512 inodes.
super-block backups (for fsck -b #) at:
 32,
Populating `foo'
makefs: Writing inode 2 (dir), bytes 0 + 2048: No space left on device

How did you produce this bug? I am not able to reproduce it on my end.

Rebased with master

emaste accepted this revision.May 26 2017, 3:43 PM

This revision is now accepted and ready to land.May 26 2017, 3:43 PM

Closed by commit rS318951: makefs: add -O (offset) option (authored by emaste). · Explain WhyMay 26 2017, 3:49 PM

This revision was automatically updated to reflect the committed changes.