makefs: make buf generic

[smahadevan_freebsdfoundation.org]

Summary

Initial changes submitted by emaste, bug fixes added by smahadevan

[ngie]

This was already committed, and the sectorsize portion of the change broke makefs.

[smahadevan_freebsdfoundation.org]

You are referring to https://svnweb.freebsd.org/base?view=revision&revision=317967 right? Was the breaking error something like: "makefs: bread: lseek 48 (-4393751551952): Invalid argument"? My bug fixes in this diff should fix the previously breaking revision. Specifically, the problem had to do with incorrectly casting a void * field in the vnode struct as fsinfo_t. Instead, this diff adds the v_fsinfo field to the struct vnode.

[emaste]

Specifically, the makefs tests pass with this fixed version of the previously-reverted change.

[emaste]

usr.sbin/makefs/ffs/ufs_inode.h

48 ↗

(On Diff #28526)

Ought to be named i_devvp for consistency with NetBSD's version.

[smahadevan_freebsdfoundation.org]

Changed i_vnode to i_devvp to maintain consistency with NetBSD

[emaste]

One more minor divergence from NetBSD noted inline. I suggest we go ahead with this change, and revisit the whitespace later on.

usr.sbin/makefs/ffs/buf.h

60 ↗

(On Diff #28540)

Should call this b_fs to match NetBSD

[smahadevan_freebsdfoundation.org]

Renamed buf and vnode fields to match NetBSD

[emaste]

What's this diff relative to? It looks like e.g ffs/buf.c does not correspond to what is currently SVN master.

[smahadevan_freebsdfoundation.org]

Ah you're right, I think I must have included a few extra commits in the diff, I'll fix this diff and make it relative to master.