makefs: style fixes and whitespace changes
Needs RevisionPublic
Actions

Authored by guest-svmhdvn on May 18 2017, 4:08 PM.

Details

Reviewers

emaste
ngie

Summary

main changes submitted by emaste, few extra additions made by smahadevan

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

guest-svmhdvn created this revision.May 18 2017, 4:08 PM

Herald added a subscriber: imp. · View Herald TranscriptMay 18 2017, 4:08 PM

emaste added a subscriber: ngie.May 18 2017, 4:18 PM

guest-svmhdvn added a child revision: D10803: makefs: make buf generic.May 18 2017, 5:38 PM

Unless these changes are in blocks of code we've written wholesale, I would leave style(9) alone. It makes it harder to merge with upstream (NetBSD).

This revision now requires changes to proceed.May 18 2017, 5:46 PM

We have new functionality, bug fixes, and style changes that are not in NetBSD today, and my plan is to submit all of our work to them once the current merge/update process is complete. Because of existing whitespace differences I have been using diff -w for comparisons with NetBSD. In some cases the ws was correct in FreeBSD, in some cases it was correct in NetBSD.

In addition, it's already not possible to merge from upstream, because of differences in macro names etc. The work that's in progress now (with a final goal of introducing msdosfs support) is proceeding by manually incorporating NetBSD changesets one by one, adapting to FreeBSD as we go.

*If* we're going to make style or whitespace changes in this code we should do it prior to functional changes.

What is the best course of action then? Are these whitespace changes ok or should we ignore this and continue with D10803?

guest-svmhdvn removed a child revision: D10803: makefs: make buf generic.May 25 2017, 2:13 PM

emaste added a subscriber: benno.May 1 2018, 6:37 PM