Page MenuHomeFreeBSD
Differential D11301

EFI boot: made 32 bit pad more explicit on EFI_MEMORY_DESCRIPTOR
ClosedPublic
Actions

Authored by siva on Jun 22 2017, 1:29 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Aug 11, 11:50 PM
Unknown Object (File)
Mon, Aug 10, 7:59 PM
Unknown Object (File)
Mon, Aug 10, 4:49 PM
Unknown Object (File)
Mon, Aug 10, 10:49 AM
Unknown Object (File)
Mon, Aug 10, 10:46 AM
Unknown Object (File)
Sat, Aug 8, 6:31 PM
Unknown Object (File)
Sat, Aug 8, 5:30 PM
Unknown Object (File)
Fri, Aug 7, 5:19 PM
View All Files
Subscribers
andrew
manu

Details

Reviewers
emaste
Commits
rS320234: Make structure padding explicit in EFI_MEMORY_DESCRIPTOR

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

siva created this revision.Jun 22 2017, 1:29 PM
emaste added a subscriber: manu.Jun 22 2017, 2:08 PM
emaste added inline comments.
sys/boot/efi/include/efidef.h
181 ↗(On Diff #29946)

I found some other instances of this file that name the field Pad and will probably do the same upon commit.

manu added a comment.Jun 22 2017, 2:12 PM

The current code matches the struct in UEFI specification 2.6 (http://www.uefi.org/sites/default/files/resources/UEFI%20Spec%202_6%20Errata%20A%20final.pdf) page 157

manu added a comment.Jun 22 2017, 2:17 PM
In D11301#234045, @manu wrote:

The current code matches the struct in UEFI specification 2.6 (http://www.uefi.org/sites/default/files/resources/UEFI%20Spec%202_6%20Errata%20A%20final.pdf) page 157

But u-boot added a u32 named reserved, not sure yet which one is wrong, I'll investigate.

andrew added a subscriber: andrew.Jun 22 2017, 2:28 PM

On 32-bit ARM there will be implicit padding as EFI_PHYSICAL_ADDRESS is a 64-bit type so will be 64-bit aligned.

Closed by commit rS320234: Make structure padding explicit in EFI_MEMORY_DESCRIPTOR (authored by emaste). · Explain WhyJun 22 2017, 2:30 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
boot/
efi/
include/
1 line

Diff 29947

View Options

head/sys/boot/efi/include/efidef.h

Loading...