Paths

Table of Contentst

EFI boot: made 32 bit pad more explicit on EFI_MEMORY_DESCRIPTOR
ClosedPublic
Actions

Authored by guest-svmhdvn on Jun 22 2017, 1:29 PM.

Tags

None

Referenced Files

	F133515931: D11301.diff
	Sun, Oct 26, 8:24 AM

	F133391555: D11301.id29946.diff
	Sat, Oct 25, 10:39 AM

	F133391545: D11301.id29947.diff
	Sat, Oct 25, 10:39 AM

	F133391539: D11301.id.diff
	Sat, Oct 25, 10:39 AM

	Unknown Object (File)
	Sat, Oct 25, 4:11 AM

	Unknown Object (File)
	Wed, Oct 15, 2:48 AM

	Unknown Object (File)
	Sat, Sep 27, 7:04 AM

	Unknown Object (File)
	Sep 19 2025, 9:06 PM

View All 63 Files

Subscribers

andrew

manu

Details

Reviewers

emaste

Commits

rS320234: Make structure padding explicit in EFI_MEMORY_DESCRIPTOR

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

guest-svmhdvn created this revision.Jun 22 2017, 1:29 PM

emaste added a subscriber: manu.Jun 22 2017, 2:08 PM

emaste added inline comments.

sys/boot/efi/include/efidef.h
181 ↗	(On Diff #29946)	I found some other instances of this file that name the field `Pad` and will probably do the same upon commit.

The current code matches the struct in UEFI specification 2.6 (http://www.uefi.org/sites/default/files/resources/UEFI%20Spec%202_6%20Errata%20A%20final.pdf) page 157

In D11301#234045, @manu wrote:

The current code matches the struct in UEFI specification 2.6 (http://www.uefi.org/sites/default/files/resources/UEFI%20Spec%202_6%20Errata%20A%20final.pdf) page 157

But u-boot added a u32 named reserved, not sure yet which one is wrong, I'll investigate.

On 32-bit ARM there will be implicit padding as EFI_PHYSICAL_ADDRESS is a 64-bit type so will be 64-bit aligned.

Closed by commit rS320234: Make structure padding explicit in EFI_MEMORY_DESCRIPTOR (authored by emaste). · Explain WhyJun 22 2017, 2:30 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

boot/

efi/

include/

efidef.h

1 line

Diff 29947

View Options

head/sys/boot/efi/include/efidef.h

EFI boot: made 32 bit pad more explicit on EFI_MEMORY_DESCRIPTORClosedPublicActions