editors/kakoune: simplify makefile

[guest-svmhdvn]

Summary

Rationale added as inline comments.

Test Plan

'make test' has the same results after the patch.

[guest-svmhdvn]

editors/kakoune/Makefile

4

Remove the use of author-generated release tarballs due to the chance of security issues caused by potential differences between the upstream repository verbatim and the author-provided tarball artifact. Refer to xz backdoor for attack vector.

14

Adding comment for why sysutils/setsid is necessary.

15

gmake is unnecessary; it builds and runs fine with built-in make.

18

This is unnecessary because there is nothing to patch now.

23

Unnecessary since upstream sets debug=no by default.

27

After upstream's move to POSIX make and the refactoring of the project's makefile, the -O3 flag will now be overriden by Ports-set make flags. This is now unnecessary.

28

We don't need to explicitly create a do-test target; the ports framework has support for adding an environment to a test target.

[diizzy]

editors/kakoune/Makefile

4

Creates more issues than it solves, see also https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-master_sites-github . We want static release archives whenever possible.

15

Good catch, have you tried builds in Poudriere so it works on all versions?

[guest-svmhdvn]

Reverted the replacement of static release tarball with USE_GITHUB.

[guest-svmhdvn]

editors/kakoune/Makefile

4

Thanks! I had originally missed that section that states:

As of 2023-02-21 GitHub have announced that source downloads will be stable for a year. Please switch to release assets and if not available ask upstream to generate ones.

15

Yes it builds fine in Poudriere, I generally do all my tests with Poudriere anyway. But could you clarify what you mean by:

so it works on all versions?

Do you mean all versions of kakoune? If so, Kakoune moved to POSIX make in 2024.xx.xx onwards so this change will work for such versions.

[guest-svmhdvn]

Refreshed patch. @ashish any feedback on this?

[ashish]

Sorry for the delay in feedback on this report. Your changes look fine to me, and they built fine, I'll commit them shortly.

editors/kakoune/Makefile

 # Created by: [e-mail]
 # $FreeBSD$
 
 PORTNAME=       libmcrypt
 PORTVERSION=    2.5.8
 PORTREVISION=   3
 CATEGORIES=     security
 MASTER_SITES=   SF/mcrypt/Libmcrypt/${PORTVERSION}
 
-MAINTAINER=     [e-mail]
+MAINTAINER=     [e-mail]
 COMMENT=        Multi-cipher cryptographic library (used in PHP)
 
-LICENSE=        LGPL21
+LICENSE=        LGPL21+
+LICENSE_FILE=   ${WRKSRC}/COPYING.LIB
 
+USES=           libtool
+USE_LDCONFIG=   yes
+
 CONFIGURE_ARGS= --enable-static
 GNU_CONFIGURE=  yes
 INSTALL_TARGET= install-strip
-USE_LDCONFIG=   yes
-USES=           libtool
 
 .include <bsd.port.mk>