editors/kakoune/Makefile
4	Remove the use of author-generated release tarballs due to the chance of security issues caused by potential differences between the upstream repository verbatim and the author-provided tarball artifact. Refer to xz backdoor for attack vector.
14	Adding comment for why `sysutils/setsid` is necessary.
15	`gmake` is unnecessary; it builds and runs fine with built-in `make`.
18	This is unnecessary because there is nothing to patch now.
23	Unnecessary since upstream sets `debug=no` by default.
27	After upstream's move to POSIX make and the refactoring of the project's makefile, the `-O3` flag will now be overriden by Ports-set make flags. This is now unnecessary.
28	We don't need to explicitly create a `do-test` target; the ports framework has support for adding an environment to a test target.

diizzy added inline comments.

editors/kakoune/Makefile
4	Creates more issues than it solves, see also https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-master_sites-github . We want static release archives whenever possible.
15	Good catch, have you tried builds in Poudriere so it works on all versions?

Reverted the replacement of static release tarball with USE_GITHUB.

editors/kakoune/Makefile
4	Thanks! I had originally missed that section that states: As of 2023-02-21 GitHub have announced that source downloads will be stable for a year. Please switch to release assets and if not available ask upstream to generate ones.
15	Yes it builds fine in Poudriere, I generally do all my tests with Poudriere anyway. But could you clarify what you mean by: so it works on all versions? Do you mean all versions of kakoune? If so, Kakoune moved to POSIX make in 2024.xx.xx onwards so this change will work for such versions.