Page MenuHomeFreeBSD

(emaste/freebsd:makefs-wip) fix bug with bread getting wrong offset and sectorsize
AbandonedPublic

Authored by smahadevan_freebsdfoundation.org on May 16 2017, 8:09 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 16, 9:38 PM
Unknown Object (File)
Sun, Apr 7, 5:37 PM
Unknown Object (File)
Mar 11 2024, 5:00 AM
Unknown Object (File)
Jan 2 2024, 1:39 AM
Unknown Object (File)
Dec 25 2023, 9:38 AM
Unknown Object (File)
Dec 20 2023, 6:43 AM
Unknown Object (File)
Dec 13 2023, 3:55 AM
Unknown Object (File)
Dec 11 2023, 10:40 PM
Subscribers

Details

Reviewers
emaste
ngie
Summary

main NetBSD commit:

  • don't abuse vp->fs to mean struct fs for ffs and struct msdos_opts

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Have you run the makefs tests, in addition to fstyp and other tests that rely on makefs yet?

Ed and I were discussing how to proceed with these changes. Instead of this review, I will post reviews for each individual feature change in makefs so it will be easier to manage. I haven't run the other tests that depend on makefs yet, I will do that before posting the other reviews. Can I abandon this revision? I will post the other reviews soon.

@ngie one other issue that we haven't fully resolved is the canonical method for running the tests on the uninstalled binary in the objdir - i.e., I'd like to do something like:

% make -C usr.sbin/makefs
% make -C usr.sbin/makefs check