Page MenuHomeFreeBSD
People des

des (Dag-Erling Smørgrav)
Committer

Projects (6)
View All

User Details

User Since
May 17 2014, 3:06 AM (595 w, 2 d)

Recent Activity
View All

Today

des closed D53027: realpath: Belatedly document POSIX conformance.
Mon, Oct 13, 11:55 AM
des closed D53025: realpath: Report correct path on failure.
Mon, Oct 13, 11:55 AM
des committed rG1406de21e176: realpath: Report correct path on failure (authored by des).
realpath: Report correct path on failure
Mon, Oct 13, 11:55 AM
des committed rG7c66667d45e9: realpath: Belatedly document POSIX conformance (authored by des).
realpath: Belatedly document POSIX conformance
Mon, Oct 13, 11:55 AM
des closed D53024: realpath: Additional test cases.
Mon, Oct 13, 11:54 AM
des committed rGf3386dfeb429: realpath: Additional test cases (authored by des).
realpath: Additional test cases
Mon, Oct 13, 11:54 AM
des abandoned D53026: realpath: Avoid doing unnecessary work.
Mon, Oct 13, 11:52 AM

Sat, Oct 11

des updated subscribers of D53026: realpath: Avoid doing unnecessary work.

@mjg @kib do you agree that there is no reason why the userland implementation of realpath() would succeed after the syscall failed, except in the case of a race?

Sat, Oct 11, 8:13 AM

Fri, Oct 10

des added a comment to D53026: realpath: Avoid doing unnecessary work.
In D53026#1211606, @markj wrote:

The only case in which the userland implementation would return a different error than the system call is if we are racing against someone modifying the hierarchy we are traversing

How do you know this? It seems possible that there are some corner cases which __realpathat() simply doesn't handle.

Fri, Oct 10, 9:27 PM
des added inline comments to D53026: realpath: Avoid doing unnecessary work.
Fri, Oct 10, 9:27 PM
des updated the diff for D53024: realpath: Additional test cases.

really fix empty case

Fri, Oct 10, 2:40 PM
des updated the diff for D53024: realpath: Additional test cases.

fix empty case

Fri, Oct 10, 2:38 PM
des updated the summary of D53027: realpath: Belatedly document POSIX conformance.
Fri, Oct 10, 2:33 PM
des requested review of D53027: realpath: Belatedly document POSIX conformance.
Fri, Oct 10, 2:26 PM
des updated the diff for D53026: realpath: Avoid doing unnecessary work.

rebase

Fri, Oct 10, 2:26 PM
des updated the diff for D53025: realpath: Report correct path on failure.

fix trailing slash

Fri, Oct 10, 2:25 PM
des updated the diff for D53024: realpath: Additional test cases.

-debug

Fri, Oct 10, 2:25 PM
des requested review of D53026: realpath: Avoid doing unnecessary work.
Fri, Oct 10, 2:05 PM
des requested review of D53025: realpath: Report correct path on failure.
Fri, Oct 10, 2:05 PM
des requested review of D53024: realpath: Additional test cases.
Fri, Oct 10, 2:05 PM
des accepted D53020: audio/sndio: Add virtual_oss to rcorder.
Fri, Oct 10, 1:02 PM
des added inline comments to D53020: audio/sndio: Add virtual_oss to rcorder.
Fri, Oct 10, 12:58 PM
des accepted D53019: virtual_oss: Clean up rcorder.
Fri, Oct 10, 12:58 PM
des added a comment to D53019: virtual_oss: Clean up rcorder.

I do not have any objection, just curious: isn't this almost the same as REQUIRE: DAEMON?

Fri, Oct 10, 12:50 PM
des added a comment to D53019: virtual_oss: Clean up rcorder.

The correct way to express that you need the network to be up is REQUIRE: NETWORKING.

Fri, Oct 10, 12:37 PM
des added a comment to D53019: virtual_oss: Clean up rcorder.

While here, require DAEMON as well.

Fri, Oct 10, 12:20 PM

Thu, Oct 9

des committed rG86d368403e65: rcorder: Fix grammar in warning about loops (authored by des).
rcorder: Fix grammar in warning about loops
Thu, Oct 9, 12:27 PM
des committed rG1c541a20989a: ln: Simplify sameness checks (authored by des).
ln: Simplify sameness checks
Thu, Oct 9, 12:22 PM
des committed rGb0c147af0862: cp: Simplify sameness checks (authored by des).
cp: Simplify sameness checks
Thu, Oct 9, 12:22 PM
des committed rG296156264072: nvme: Tweak completion timeout loop (authored by des).
nvme: Tweak completion timeout loop
Thu, Oct 9, 12:22 PM
des committed rG86eecff20db7: rcorder: Fix grammar in warning about loops (authored by des).
rcorder: Fix grammar in warning about loops
Thu, Oct 9, 12:22 PM
des committed rGce6061658f84: tail: Tweak follow_rename test case (authored by des).
tail: Tweak follow_rename test case
Thu, Oct 9, 12:22 PM
des committed rG6a9e0fdf3713: tarfs: Simplify sameness checks (authored by des).
tarfs: Simplify sameness checks
Thu, Oct 9, 12:22 PM
des committed rG23b82b5b4473: ln: Simplify sameness checks (authored by des).
ln: Simplify sameness checks
Thu, Oct 9, 12:22 PM
des committed rGef8420744e72: cp: Simplify sameness checks (authored by des).
cp: Simplify sameness checks
Thu, Oct 9, 12:22 PM
des committed rG12304ec66239: fts: Remove a few stray blank lines (authored by des).
fts: Remove a few stray blank lines
Thu, Oct 9, 12:22 PM
des committed rG835f8ac7d06f: tail: Tweak follow_rename test case (authored by des).
tail: Tweak follow_rename test case
Thu, Oct 9, 12:22 PM
des committed rGdf70662f4704: rc: Teach netwait to wait for DAD (authored by des).
rc: Teach netwait to wait for DAD
Thu, Oct 9, 12:22 PM
des committed rGb2f1fa13e98f: fts: Document thread (un)safety (authored by des).
fts: Document thread (un)safety
Thu, Oct 9, 12:22 PM
des committed rGc2fd9060f32d: nvme: Tweak completion timeout loop (authored by des).
nvme: Tweak completion timeout loop
Thu, Oct 9, 12:22 PM
des committed rG4fe1317fd986: rcorder: Fix grammar in warning about loops (authored by des).
rcorder: Fix grammar in warning about loops
Thu, Oct 9, 12:22 PM
des committed rG1a7f745833dd: tarfs: Simplify sameness checks (authored by des).
tarfs: Simplify sameness checks
Thu, Oct 9, 12:22 PM
des committed rGf5060534b4f1: ln: Simplify sameness checks (authored by des).
ln: Simplify sameness checks
Thu, Oct 9, 12:22 PM
des committed rG74fa49276487: cp: Simplify sameness checks (authored by des).
cp: Simplify sameness checks
Thu, Oct 9, 12:22 PM
des committed rG7143adb76524: fts: Remove a few stray blank lines (authored by des).
fts: Remove a few stray blank lines
Thu, Oct 9, 12:22 PM
des committed rGed7cdc3e354d: tail: Tweak follow_rename test case (authored by des).
tail: Tweak follow_rename test case
Thu, Oct 9, 12:22 PM
des committed rGb8d62b94b994: rc: Teach netwait to wait for DAD (authored by des).
rc: Teach netwait to wait for DAD
Thu, Oct 9, 12:22 PM
des committed rG8c9b3ad2ec2a: fts: Document thread (un)safety (authored by des).
fts: Document thread (un)safety
Thu, Oct 9, 12:22 PM

Wed, Oct 8

des closed D52977: local-unbound-setup: Set so-sndbuf to 0.
Wed, Oct 8, 4:47 PM
des committed rGde3faa85d8f9: local-unbound-setup: Set so-sndbuf to 0 (authored by des).
local-unbound-setup: Set so-sndbuf to 0
Wed, Oct 8, 4:47 PM
des added a comment to D52981: unbound: Reverse two upstream commits setting so_sndbuf default.

You really don't want to go down this route. D52977 is enough.

Wed, Oct 8, 3:15 PM
des committed rGd96f9a468866: rcorder: Fix grammar in warning about loops (authored by des).
rcorder: Fix grammar in warning about loops
Wed, Oct 8, 10:08 AM
des committed rG4070ae0e9a60: nvme: Tweak completion timeout loop (authored by des).
nvme: Tweak completion timeout loop
Wed, Oct 8, 10:08 AM
des closed D52951: rcorder: Fix grammar in warning about loops.
Wed, Oct 8, 10:07 AM
des closed D52973: nvme: Tweak completion timeout loop.
Wed, Oct 8, 10:07 AM
des requested review of D52977: local-unbound-setup: Set so-sndbuf to 0.
Wed, Oct 8, 9:57 AM
des requested review of D52973: nvme: Tweak completion timeout loop.
Wed, Oct 8, 12:58 AM

Tue, Oct 7

des accepted D52953: rc: Update dependencies for zpool scripts.
Tue, Oct 7, 4:39 PM
des accepted D52954: rc tests: Add a test to check for warnings from rcorder.
Tue, Oct 7, 4:38 PM
des committed rG1b0fce2944e3: tarfs: Simplify sameness checks (authored by des).
tarfs: Simplify sameness checks
Tue, Oct 7, 4:26 PM
des closed D52928: tarfs: Simplify sameness checks.
Tue, Oct 7, 4:26 PM
des committed rG18997fb9eca6: ln: Simplify sameness checks (authored by des).
ln: Simplify sameness checks
Tue, Oct 7, 4:25 PM
des closed D52927: ln: Simplify sameness checks.
Tue, Oct 7, 4:25 PM
des committed rG95de78614a57: cp: Simplify sameness checks (authored by des).
cp: Simplify sameness checks
Tue, Oct 7, 4:25 PM
des closed D52926: cp: Simplify sameness checks.
Tue, Oct 7, 4:25 PM
des committed rGa802334d86c7: fts: Further improve the manual page (authored by des).
fts: Further improve the manual page
Tue, Oct 7, 4:25 PM
des closed D52925: fts: Further improve the manual page.
Tue, Oct 7, 4:25 PM
des closed D52924: fts: Remove a few stray blank lines.
Tue, Oct 7, 4:25 PM
des committed rG31db1582c883: fts: Remove a few stray blank lines (authored by des).
fts: Remove a few stray blank lines
Tue, Oct 7, 4:25 PM
des closed D52887: tail: Tweak follow_rename test case.
Tue, Oct 7, 4:24 PM
des committed rGa9c72543d287: tail: Tweak follow_rename test case (authored by des).
tail: Tweak follow_rename test case
Tue, Oct 7, 4:24 PM
des added inline comments to D52954: rc tests: Add a test to check for warnings from rcorder.
Tue, Oct 7, 2:47 PM
des requested review of D52951: rcorder: Fix grammar in warning about loops.
Tue, Oct 7, 9:37 AM
des added inline comments to D52925: fts: Further improve the manual page.
Tue, Oct 7, 9:13 AM
des updated the diff for D52925: fts: Further improve the manual page.

rf

Tue, Oct 7, 9:13 AM

Mon, Oct 6

des updated the diff for D52926: cp: Simplify sameness checks.

rf

Mon, Oct 6, 12:47 PM
des added inline comments to D52926: cp: Simplify sameness checks.
Mon, Oct 6, 12:45 PM
des added inline comments to D52926: cp: Simplify sameness checks.
Mon, Oct 6, 12:43 PM
des added a reviewer for D52925: fts: Further improve the manual page: manpages.
Mon, Oct 6, 9:31 AM
des accepted D52882: nss_tacplus: Fix typo MK_INSTALLIB -> MK_INSTALLLIB.
Mon, Oct 6, 9:30 AM
des requested review of D52928: tarfs: Simplify sameness checks.
Mon, Oct 6, 9:26 AM
des requested review of D52927: ln: Simplify sameness checks.
Mon, Oct 6, 9:26 AM
des requested review of D52926: cp: Simplify sameness checks.
Mon, Oct 6, 9:25 AM
des requested review of D52925: fts: Further improve the manual page.
Mon, Oct 6, 9:25 AM
des requested review of D52924: fts: Remove a few stray blank lines.
Mon, Oct 6, 9:25 AM

Sun, Oct 5

des closed D52905: rc: Improve netwait DAD logic.
Sun, Oct 5, 6:43 PM
des committed rGec6ad605ecea: rc: Improve netwait DAD logic (authored by des).
rc: Improve netwait DAD logic
Sun, Oct 5, 6:43 PM
des added inline comments to D52905: rc: Improve netwait DAD logic.
Sun, Oct 5, 6:40 PM

Sat, Oct 4

des updated the diff for D52905: rc: Improve netwait DAD logic.

rf

Sat, Oct 4, 8:41 PM
des added inline comments to D52905: rc: Improve netwait DAD logic.
Sat, Oct 4, 8:39 PM
des updated the diff for D52887: tail: Tweak follow_rename test case.

rf

Sat, Oct 4, 6:44 PM
des committed rG64f8416afd4c: fts: Document thread (un)safety (authored by des).
fts: Document thread (un)safety
Sat, Oct 4, 6:43 PM
des closed D52828: fts: Document thread (un)safety.
Sat, Oct 4, 6:43 PM
des added inline comments to D52882: nss_tacplus: Fix typo MK_INSTALLIB -> MK_INSTALLLIB.
Sat, Oct 4, 6:35 PM
des requested review of D52905: rc: Improve netwait DAD logic.
Sat, Oct 4, 6:32 PM

Fri, Oct 3

des updated the diff for D52828: fts: Document thread (un)safety.

subsections

Fri, Oct 3, 5:11 PM
des added a comment to D52828: fts: Document thread (un)safety.

Should I convert the function sections to subsections while I'm at it?

Fri, Oct 3, 4:58 PM
des requested changes to D52882: nss_tacplus: Fix typo MK_INSTALLIB -> MK_INSTALLLIB.

Please also add usr/lib/libnss_tacplus.a to ObsoleteFiles.inc.

Fri, Oct 3, 4:56 PM
des requested review of D52887: tail: Tweak follow_rename test case.
Fri, Oct 3, 4:12 PM

Thu, Oct 2

des committed rG5ead817c3b7a: rc: Teach netwait to wait for DAD (authored by des).
rc: Teach netwait to wait for DAD
Thu, Oct 2, 9:33 AM