Page MenuHomeFreeBSD
Differential D55793

m4: Stop abbreviating builtin names
ClosedPublic
Actions

Authored by des on Tue, Mar 10, 11:15 AM.
Tags
None
Referenced Files
F151382587: D55793.id174251.diff
Wed, Apr 8, 1:07 AM
Unknown Object (File)
Mon, Apr 6, 4:23 PM
Unknown Object (File)
Sun, Apr 5, 12:53 PM
Unknown Object (File)
Sun, Apr 5, 3:31 AM
Unknown Object (File)
Tue, Mar 31, 2:28 PM
Unknown Object (File)
Tue, Mar 31, 9:21 AM
Unknown Object (File)
Thu, Mar 19, 5:52 PM
Unknown Object (File)
Wed, Mar 18, 4:16 AM
View All 16 Files
Subscribers
fuz
imp

Details

Reviewers
None
Commits
rGe4755b918372: m4: Stop abbreviating builtin names
rGa6eda8dd2d6b: m4: Stop abbreviating builtin names
rGb1953338a34e: m4: Stop abbreviating builtin names
rGf8f6f1cbd576: m4: Stop abbreviating builtin names
Summary
  • Stop abbreviating macro names half-randomly to 8 chars, this is no longer 1990.
  • Likewise for function names (in particular use doindex for a function that is notably different from the classic index function).
  • Rename a few things for more fidelity: eval is the builtin name, not expr and your maketemp/mkstemp conform to mkstemp semantics for better security.
  • Rewrap a few comments that were ludicrously short.

No functional changes except improved accuracy of some error messages.

MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des created this revision.Tue, Mar 10, 11:15 AM
Herald added a subscriber: imp. · View Herald TranscriptTue, Mar 10, 11:15 AM
des requested review of this revision.Tue, Mar 10, 11:15 AM
Harbormaster completed remote builds in B71309: Diff 173497.Tue, Mar 10, 11:15 AM
des updated this revision to Diff 173499.Tue, Mar 10, 12:02 PM

remove unrelated whitespace changes

Harbormaster completed remote builds in B71310: Diff 173499.Tue, Mar 10, 12:02 PM
des added a child revision: D55794: m4: Misc style fixes.Tue, Mar 10, 12:18 PM
fuz added a subscriber: fuz.Sun, Mar 15, 3:52 PM
fuz added inline comments.
usr.bin/m4/main.c
114

It would be better for this to stay as EXPRTYPE. The rename seems unmotivated.

usr.bin/m4/mdef.h
44–87

Could this be changed to an enum?

des added inline comments.Sun, Mar 15, 4:18 PM
usr.bin/m4/main.c
114

The proper name of this builtin is eval; expr is a non-standard alias.

usr.bin/m4/mdef.h
44–87

Yes, it could.

This revision was not accepted when it landed; it landed in state Needs Review.Wed, Mar 25, 12:42 AM
Closed by commit rGf8f6f1cbd576: m4: Stop abbreviating builtin names (authored by Marc Espie <espie@openbsd.org>, committed by des). · Explain Why
This revision was automatically updated to reflect the committed changes.
des added a commit: rGf8f6f1cbd576: m4: Stop abbreviating builtin names.
des added a commit: rGb1953338a34e: m4: Stop abbreviating builtin names.Thu, Apr 2, 9:48 AM
des added a commit: rGa6eda8dd2d6b: m4: Stop abbreviating builtin names.
des added a commit: rGe4755b918372: m4: Stop abbreviating builtin names.

Revision Contents
Changeset List

PathSize
usr.bin/
m4/
184 lines
2 lines
6 lines
65 lines
88 lines
2 lines

Diff 174251

View Options

usr.bin/m4/eval.c

Loading...
View Options

usr.bin/m4/extern.h

Loading...
View Options

usr.bin/m4/look.c

Loading...
View Options

usr.bin/m4/main.c

Loading...
View Options

usr.bin/m4/mdef.h

Loading...
View Options

usr.bin/m4/misc.c

Loading...