Page MenuHomeFreeBSD
Differential D55794

m4: Misc style fixes
ClosedPublic
Actions

Authored by des on Tue, Mar 10, 12:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 4, 9:54 AM
Unknown Object (File)
Sat, Apr 4, 8:13 AM
Unknown Object (File)
Sat, Apr 4, 7:43 AM
Unknown Object (File)
Sat, Apr 4, 1:27 AM
Unknown Object (File)
Thu, Apr 2, 6:24 AM
Unknown Object (File)
Mon, Mar 23, 5:09 AM
Unknown Object (File)
Sun, Mar 22, 8:18 PM
Unknown Object (File)
Fri, Mar 20, 2:40 AM
View All 14 Files
Subscribers
fuz
imp

Details

Reviewers
fuz
Commits
rG3396afba986b: m4: Misc style fixes
rGbc735d80e2e8: m4: Misc style fixes
rG3ef292118937: m4: Misc style fixes
rG41474e78c493: m4: Misc style fixes
Summary

MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des created this revision.Tue, Mar 10, 12:18 PM
Herald added a subscriber: imp. · View Herald TranscriptTue, Mar 10, 12:18 PM
des requested review of this revision.Tue, Mar 10, 12:18 PM
Harbormaster completed remote builds in B71311: Diff 173500.Tue, Mar 10, 12:18 PM
des added a parent revision: D55793: m4: Stop abbreviating builtin names.Tue, Mar 10, 12:18 PM
fuz requested changes to this revision.Sun, Mar 15, 3:49 PM
fuz added a subscriber: fuz.

I would get rid of the type changes, as I don't think they actually improve the code. The end_result change is wrong.

usr.bin/m4/expr.c
24

This is an external variable in parser.y, the type int32_t is correct. If at all, it should be adjusted to YYSTYPE after including parser.h.

35

Following style(9).

usr.bin/m4/extern.h
161 ↗(On Diff #173500)

I don't see the point of these type changes.

This revision now requires changes to proceed.Sun, Mar 15, 3:49 PM
des updated this revision to Diff 173730.Sun, Mar 15, 4:40 PM

unbreak

Harbormaster completed remote builds in B71415: Diff 173730.Sun, Mar 15, 4:40 PM
fuz requested changes to this revision.Sun, Mar 15, 4:47 PM
fuz added inline comments.
usr.bin/m4/look.c
221

ohash_first takes a pointer to an unsigned int. This change is incorrect.

254

Same here.

usr.bin/m4/parser.y
21 ↗(On Diff #173730)

This change makes it so that the type of an m4 expression is potentially platform dependent. Is this desired?

In particular, m4(1) documents that 32-bit arithmetic is used, so it should really stay int32_t.

This revision now requires changes to proceed.Sun, Mar 15, 4:47 PM
des updated this revision to Diff 173731.Sun, Mar 15, 4:53 PM

rf

Harbormaster completed remote builds in B71416: Diff 173731.Sun, Mar 15, 4:53 PM
des added inline comments.Sun, Mar 15, 4:54 PM
usr.bin/m4/expr.c
35

The first rule is to be consistent, and m4 consistently does not parenthesize its return values.

des marked an inline comment as done.Mon, Mar 16, 8:38 PM
des updated this revision to Diff 174250.Wed, Mar 25, 12:32 AM

rf

Harbormaster completed remote builds in B71698: Diff 174250.Wed, Mar 25, 12:32 AM
des retitled this revision from m4: Misc type and style fixes to m4: Misc style fixes.Wed, Mar 25, 12:32 AM
fuz accepted this revision.Wed, Mar 25, 12:34 AM
fuz added inline comments.
usr.bin/m4/expr.c
35

Fair enough.

This revision is now accepted and ready to land.Wed, Mar 25, 12:34 AM
Closed by commit rG41474e78c493: m4: Misc style fixes (authored by des). · Explain WhyWed, Mar 25, 12:42 AM
This revision was automatically updated to reflect the committed changes.
des added a commit: rG41474e78c493: m4: Misc style fixes.
des added a commit: rG3ef292118937: m4: Misc style fixes.Thu, Apr 2, 9:49 AM
des added a commit: rGbc735d80e2e8: m4: Misc style fixes.
des added a commit: rG3396afba986b: m4: Misc style fixes.

Revision Contents
Changeset List

PathSize
usr.bin/
m4/
18 lines
2 lines
17 lines
5 lines
2 lines
12 lines

Diff 174252

View Options

usr.bin/m4/eval.c

Loading...
View Options

usr.bin/m4/expr.c

Loading...
View Options

usr.bin/m4/look.c

Loading...
View Options

usr.bin/m4/main.c

Loading...
View Options

usr.bin/m4/mdef.h

Loading...
View Options

usr.bin/m4/misc.c

Loading...