system(3): Unwrap execve()
ClosedPublic
Actions

Authored by des on Wed, Mar 4, 2:43 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Mar 7, 8:17 AM

	Unknown Object (File)
	Fri, Mar 6, 11:20 AM

	Unknown Object (File)
	Thu, Mar 5, 12:02 PM

	Unknown Object (File)
	Thu, Mar 5, 8:54 AM

	Unknown Object (File)
	Thu, Mar 5, 8:53 AM

	Unknown Object (File)
	Thu, Mar 5, 6:44 AM

	Unknown Object (File)
	Thu, Mar 5, 6:44 AM

	Unknown Object (File)
	Thu, Mar 5, 4:36 AM

Subscribers

imp

Details

Reviewers

kevans

Group Reviewers

Klara

Commits

rG40e52e0edd03: system(3): Unwrap execve()

Summary

There is no need to call execl(), which will allocate an array and copy
our arguments into it, when we can use a static array and call execve()
directly.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

des created this revision.Wed, Mar 4, 2:43 PM

Herald added a subscriber: imp. · View Herald TranscriptWed, Mar 4, 2:43 PM

des requested review of this revision.Wed, Mar 4, 2:43 PM

Harbormaster completed remote builds in B71178: Diff 173114.Wed, Mar 4, 2:43 PM

kevans accepted this revision.Wed, Mar 4, 2:49 PM

This revision is now accepted and ready to land.Wed, Mar 4, 2:49 PM

Closed by commit rG40e52e0edd03: system(3): Unwrap execve() (authored by des). · Explain WhyWed, Mar 4, 3:23 PM

This revision was automatically updated to reflect the committed changes.

des added a commit: rG40e52e0edd03: system(3): Unwrap execve().

Revision Contents
Changeset List

Path

Size

lib/

libc/

stdlib/

system.c

4 lines

Diff 173132

View Options

system(3): Unwrap execve()ClosedPublicActions