libutil: convert the trimdomain tests to atf-c(3)

[kevans]

Summary

The previous version of these tests didn't report failures via the
exit status, which is fine with Kyua (has a TAP parser) but not as
friendly to other test runners. This would have been an easy fix, but
let's just convert these to atf-c(3) since there's no reason we can't
actually run all of the included cases in parallel.

While we're here, eliminate duplication by just having the -nodomain
test #include the domained version with a different value for
TESTDOMAIN. No functional change from this aspect, besides running the
longhostsize test case in both.

[asomers]

LGTM.

[ngie]

lib/libutil/tests/Makefile

8

Why the rename..?

8

Why the rename..?

Nevermind. I misread the diff below.

[des]

lib/libutil/tests/trimdomain-nodomain_test.c

2

Why not just drop this file and add two nodomain test cases to the other?

[kevans]

lib/libutil/tests/trimdomain-nodomain_test.c

2

Fair point- trimdomain's caching doesn't matter in the atf model since we can't physically run two tests in the same execution.

[ngie]

lib/libutil/tests/trimdomain_test.c

26

This isn't necessary per style(9).