Setting every single cpuid value seems to be a bunch of work for user. Especially, as user have to set every single bit correctly. What's the way forward for this? How will bhyve receive some default cpuid values?

This should be merged into the previous commit D51552 shouldn't it?

Could you please describe a use case in the commit message?

• rename len to size to match common naming in pci_passthru.c

• use uint64_t instead of vm_* types
• account for new handler interface (including baridx)

• use uint64_t instead of vm_* types

• use uint64_t types instead of vm_* types
• add baridx parameter to read/write handler
  • this parameter can be used in the future to e.g. add a generic PCI config mirror in BAR space which is quite common according to QEMU [1]

@markj @jhb Any additional comments?

• fix build

• fix style issue
• use correct offset for 64 bit BDSM read/writes

• fix style issues
• make use of trunc_page and round_page

• fix style issues
• make global variables const

Becomes obsolete by D50806 and D50807.

• rebase onto main

• rebase onto main

• rebase onto main

• rebase onto main

• make use of igd_ops

• rebase onto main

Any comments on this?

Any comments on this?

In D46562#1064622, @rosenfeld_grumpf.hope-2000.org wrote:

Do I need a more elaborate commit message here, too?

Also, and in general, where do testing notes go, assuming they are needed?

Where's the commit message?

It would be a very good idea to improve your commit message. It would be nice to explain the use case in more detail (if possible). Additionally, it would be great to mention limitations of this new feature e.g. that user have to make sure to protect the tcp socket from unprivileged access.

ping

ping

ping

ping

ping

Please add a commit message.

Is this ready? So far, LGTM.

In D46402#1059143, @mp wrote:

@corvink thank you for the reviews. Hopefully these last changes should address all of your feedback.

LGTM. Will test it.

• avoid code duplication by moving the code below element insertion

• use a new top level case to detect empty entries

@markj @jhb Any feedback?