Page MenuHomeFreeBSD

corvink (Corvin Köhne)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 27 2020, 6:07 AM (267 w, 3 d)

Recent Activity

Fri, Oct 10

corvink accepted D53013: vmm: Remove some unused macros.
Fri, Oct 10, 5:52 AM
corvink accepted D53012: vmm: Move the guest vmspace into the generic vm_mem structure.
Fri, Oct 10, 5:52 AM
corvink accepted D53011: vmm: Make vmmops declarations more consistent.
Fri, Oct 10, 5:49 AM
corvink accepted D53010: vmm: Unify implementations of vcpu_cleanup().
Fri, Oct 10, 5:47 AM

Thu, Oct 9

corvink added inline comments to D52781: sys/amd64/vmm: fix Windows 11 deadlock.
Thu, Oct 9, 12:27 PM

Tue, Oct 7

corvink added inline comments to D52781: sys/amd64/vmm: fix Windows 11 deadlock.
Tue, Oct 7, 6:24 AM

Mon, Oct 6

corvink added inline comments to D52781: sys/amd64/vmm: fix Windows 11 deadlock.
Mon, Oct 6, 1:44 PM
corvink added a comment to D52781: sys/amd64/vmm: fix Windows 11 deadlock.

I think there may still be a relationship, jbo, since I've been having a different experience than you. However for now I'll try out some other bisecting before coming back to this. I'm going to test out switching out the "nvme" emulation for my drive to "ahci-hd" and see if that has any stability effect. I know people have also experienced issues with the nvme emulation before.

Mon, Oct 6, 7:46 AM
corvink updated the summary of D52781: sys/amd64/vmm: fix Windows 11 deadlock.
Mon, Oct 6, 7:42 AM
corvink updated the diff for D52781: sys/amd64/vmm: fix Windows 11 deadlock.
  • only unlock vcpu when necessary
  • avoid uneccessary sleeps
  • fix some style issues
Mon, Oct 6, 7:42 AM

Thu, Oct 2

corvink added inline comments to D52781: sys/amd64/vmm: fix Windows 11 deadlock.
Thu, Oct 2, 8:02 AM

Wed, Oct 1

corvink added inline comments to D52781: sys/amd64/vmm: fix Windows 11 deadlock.
Wed, Oct 1, 7:21 PM

Tue, Sep 30

corvink added inline comments to D52781: sys/amd64/vmm: fix Windows 11 deadlock.
Tue, Sep 30, 2:19 PM

Mon, Sep 29

corvink added a comment to D37972: bhyve: help rendezvous request when waiting for IDLE vcpu state.

Hi,
I'm able to reproduce the issue and was able to fix it: https://reviews.freebsd.org/D52781

Mon, Sep 29, 9:42 AM
corvink requested review of D52781: sys/amd64/vmm: fix Windows 11 deadlock.
Mon, Sep 29, 9:41 AM

Tue, Sep 23

corvink committed rGd0efd64479ed: bhyve: assign a valid INTPIN to NVIDIA GPUs (authored by corvink).
bhyve: assign a valid INTPIN to NVIDIA GPUs
Tue, Sep 23, 2:30 PM
corvink committed rG5a8172dd6389: bhyve: assign a valid INTPIN to NVIDIA GPUs (authored by corvink).
bhyve: assign a valid INTPIN to NVIDIA GPUs
Tue, Sep 23, 2:05 PM

Tue, Sep 16

corvink added a comment to D52013: bhyve: allow passthrough of sub-page MMIO BARs.

I'm not sure but it might be possible to use an RB tree [1] to simplify creating a list, sorting it and searching for elements (RB_NFIND).

Tue, Sep 16, 8:16 AM
corvink added inline comments to D52013: bhyve: allow passthrough of sub-page MMIO BARs.
Tue, Sep 16, 7:51 AM
corvink committed rGeffcd0ded0ef: bhyve: assign a valid INTPIN to NVIDIA GPUs (authored by corvink).
bhyve: assign a valid INTPIN to NVIDIA GPUs
Tue, Sep 16, 6:57 AM
corvink closed D51892: bhyve: assign a valid INTPIN to NVIDIA GPUs.
Tue, Sep 16, 6:57 AM

Mon, Sep 15

corvink accepted D52425: bhyve: tpm: Avoid printing a message when clearing the cancel bit.
Mon, Sep 15, 10:16 AM

Aug 15 2025

corvink added a comment to D51892: bhyve: assign a valid INTPIN to NVIDIA GPUs.
In D51892#1186266, @jhb wrote:

Hmmm, do we not support INTx interrupts for passthrough in general? I guess we don't. There's a chance some guest OS might try to use INTx instead of MSI which won't work. Do you have more context on what is requiring this? Is it a driver in a Windows guest, or some other OS?

Aug 15 2025, 9:13 AM

Aug 14 2025

corvink requested review of D51892: bhyve: assign a valid INTPIN to NVIDIA GPUs.
Aug 14 2025, 6:10 AM

Aug 5 2025

corvink committed rG6374c45fbaf7: bhyve: protect MMIO mapped BDSM register (authored by corvink).
bhyve: protect MMIO mapped BDSM register
Aug 5 2025, 2:04 PM
corvink committed rG6dda2653bd0e: bhyve: add interface to protect BAR regions of passthru devices (authored by corvink).
bhyve: add interface to protect BAR regions of passthru devices
Aug 5 2025, 2:04 PM
corvink committed rGf841cb63687b: bhyve: trap protected BAR regions of passthru devices (authored by corvink).
bhyve: trap protected BAR regions of passthru devices
Aug 5 2025, 2:04 PM
corvink committed rGdf6c805ca125: bhyve: add BAR handler list for passthru devices (authored by corvink).
bhyve: add BAR handler list for passthru devices
Aug 5 2025, 2:04 PM
corvink closed D45342: bhyve: protect MMIO mapped BDSM register.
Aug 5 2025, 2:04 PM
corvink committed rG9eddbaa5bba2: bhyve: add GVT-d support for graphics gen 11 and newer (authored by corvink).
bhyve: add GVT-d support for graphics gen 11 and newer
Aug 5 2025, 2:04 PM
corvink closed D45341: bhyve: add interface to protect BAR regions of passthru devices.
Aug 5 2025, 2:04 PM
corvink closed D45340: bhyve: trap protected BAR regions of passthru devices.
Aug 5 2025, 2:04 PM
corvink committed rG1bc515184d87: bhyve: scan PCI device ID to properly set BDSM address (authored by corvink).
bhyve: scan PCI device ID to properly set BDSM address
Aug 5 2025, 2:04 PM
corvink closed D45339: bhyve: add BAR handler list for passthru devices.
Aug 5 2025, 2:04 PM
corvink closed D45338: bhyve: add GVT-d support for graphics gen 11 and newer.
Aug 5 2025, 2:04 PM
corvink closed D50807: bhyve: scan PCI device ID to properly set BDSM address.
Aug 5 2025, 2:04 PM

Jul 28 2025

corvink added a comment to D51555: bhyve/amd64: parse cpuid options.

Setting every single cpuid value seems to be a bunch of work for user. Especially, as user have to set every single bit correctly. What's the way forward for this? How will bhyve receive some default cpuid values?

Jul 28 2025, 9:56 AM
corvink added inline comments to D51555: bhyve/amd64: parse cpuid options.
Jul 28 2025, 9:53 AM
corvink accepted D51554: libvmmapi/amd64: add support for CPUID ioctls to libvmmapi.
Jul 28 2025, 9:39 AM
corvink added a comment to D51553: vmm/amd64: VM_SET_CPUID ioctl should refuse zero-entry non-legacy cpuid cfg.

This should be merged into the previous commit D51552 shouldn't it?

Jul 28 2025, 9:38 AM
corvink added inline comments to D51552: vmm/amd64: port illumos cpuid control.
Jul 28 2025, 9:37 AM
corvink accepted D51551: bhyve: want walk_config_nodes.

Could you please describe a use case in the commit message?

Jul 28 2025, 9:06 AM
corvink accepted D51550: amd64: add missing include sys/pcpu.h to vmm_host.h and md_var.h.
Jul 28 2025, 9:03 AM

Jun 27 2025

corvink updated the diff for D45340: bhyve: trap protected BAR regions of passthru devices.
  • rename len to size to match common naming in pci_passthru.c
Jun 27 2025, 7:47 AM
corvink updated the diff for D45342: bhyve: protect MMIO mapped BDSM register.
  • use uint64_t instead of vm_* types
  • account for new handler interface (including baridx)
Jun 27 2025, 7:41 AM
corvink updated the diff for D45341: bhyve: add interface to protect BAR regions of passthru devices.
  • use uint64_t instead of vm_* types
Jun 27 2025, 7:40 AM
corvink updated the diff for D45339: bhyve: add BAR handler list for passthru devices.
  • use uint64_t types instead of vm_* types
  • add baridx parameter to read/write handler
    • this parameter can be used in the future to e.g. add a generic PCI config mirror in BAR space which is quite common according to QEMU [1]
Jun 27 2025, 7:39 AM
corvink added a comment to D50807: bhyve: scan PCI device ID to properly set BDSM address.

@markj @jhb Any additional comments?

Jun 27 2025, 6:44 AM
corvink updated the diff for D50807: bhyve: scan PCI device ID to properly set BDSM address.
  • fix build
Jun 27 2025, 6:43 AM

Jun 24 2025

corvink updated the diff for D45342: bhyve: protect MMIO mapped BDSM register.
  • fix style issue
  • use correct offset for 64 bit BDSM read/writes
Jun 24 2025, 6:27 AM
corvink updated the diff for D45340: bhyve: trap protected BAR regions of passthru devices.
  • fix style issues
  • make use of trunc_page and round_page
Jun 24 2025, 6:24 AM
corvink committed rGfb2b8c307d2e: bhyve: add PCI IDs of Intel GPUs from Linux v6.15 (authored by corvink).
bhyve: add PCI IDs of Intel GPUs from Linux v6.15
Jun 24 2025, 6:15 AM
corvink committed rGb2221534a7bc: bhyve: support VBTs which lay outside of the OpRegion (authored by corvink).
bhyve: support VBTs which lay outside of the OpRegion
Jun 24 2025, 6:15 AM
corvink closed D50806: bhyve: add PCI IDs of Intel GPUs from Linux v6.15.
Jun 24 2025, 6:15 AM
corvink closed D45337: bhyve: support VBTs which lay outside of the OpRegion.
Jun 24 2025, 6:15 AM
corvink added inline comments to D45339: bhyve: add BAR handler list for passthru devices.
Jun 24 2025, 6:07 AM
corvink updated the diff for D50807: bhyve: scan PCI device ID to properly set BDSM address.
  • fix style issues
  • make global variables const
Jun 24 2025, 5:54 AM

Jun 17 2025

corvink added inline comments to D50806: bhyve: add PCI IDs of Intel GPUs from Linux v6.15.
Jun 17 2025, 6:34 AM

Jun 12 2025

corvink updated the summary of D50806: bhyve: add PCI IDs of Intel GPUs from Linux v6.15.
Jun 12 2025, 1:51 PM
corvink abandoned D45333: x86/pci: add sysctl for intel_graphics_gen.

Becomes obsolete by D50806 and D50807.

Jun 12 2025, 1:48 PM
corvink updated the diff for D45342: bhyve: protect MMIO mapped BDSM register.
  • rebase onto main
Jun 12 2025, 1:47 PM
corvink updated the diff for D45341: bhyve: add interface to protect BAR regions of passthru devices.
  • rebase onto main
Jun 12 2025, 1:46 PM
corvink updated the diff for D45340: bhyve: trap protected BAR regions of passthru devices.
  • rebase onto main
Jun 12 2025, 1:46 PM
corvink updated the diff for D45339: bhyve: add BAR handler list for passthru devices.
  • rebase onto main
Jun 12 2025, 1:46 PM
corvink updated the diff for D45338: bhyve: add GVT-d support for graphics gen 11 and newer.
  • make use of igd_ops
Jun 12 2025, 1:46 PM
corvink requested review of D50807: bhyve: scan PCI device ID to properly set BDSM address.
Jun 12 2025, 1:46 PM
corvink requested review of D50806: bhyve: add PCI IDs of Intel GPUs from Linux v6.15.
Jun 12 2025, 1:45 PM
corvink updated the diff for D45337: bhyve: support VBTs which lay outside of the OpRegion.
  • rebase onto main
Jun 12 2025, 1:45 PM

May 19 2025

corvink committed rGe9fe7b08eb2e: sys/intpm: fix SMBus Read Block (authored by corvink).
sys/intpm: fix SMBus Read Block
May 19 2025, 12:54 PM

May 6 2025

corvink committed rG691833ad3776: sys/intpm: fix SMBus Read Block (authored by corvink).
sys/intpm: fix SMBus Read Block
May 6 2025, 11:55 AM

Feb 4 2025

corvink accepted D48811: bhyve: Sleep for a short period after VM_EXITCODE_DEBUG exits.
Feb 4 2025, 7:38 AM

Jan 21 2025

corvink added inline comments to D45333: x86/pci: add sysctl for intel_graphics_gen.
Jan 21 2025, 7:17 AM

Jan 20 2025

corvink added a comment to D45337: bhyve: support VBTs which lay outside of the OpRegion.

Any comments on this?

Jan 20 2025, 8:31 AM
corvink added a comment to D45333: x86/pci: add sysctl for intel_graphics_gen.

Any comments on this?

Jan 20 2025, 8:30 AM

Jan 6 2025

corvink accepted D48269: vmm: Fix error handling in vmm_handler().
Jan 6 2025, 7:42 AM
corvink accepted D48268: amd64/vmm: Rename vm_get_vmspace() to vm_vmspace().
Jan 6 2025, 7:38 AM
corvink accepted D48267: amd64/vmm: Remove vmm_mem_init().
Jan 6 2025, 7:37 AM

Nov 12 2024

corvink committed rGfe019d5e443b: bhyve: TPM 2.0 emulation with swtpm (authored by rosenfeld_grumpf.hope-2000.org).
bhyve: TPM 2.0 emulation with swtpm
Nov 12 2024, 7:56 AM
corvink committed rGb3180bea9b1d: bhyve: TPM CRB: pass actual TPM request length to backend execute_cmd() (authored by rosenfeld_grumpf.hope-2000.org).
bhyve: TPM CRB: pass actual TPM request length to backend execute_cmd()
Nov 12 2024, 7:56 AM
corvink committed rG5a43d257c0fe: bhyve: don't crash when guest writes TPM int_enable register (authored by rosenfeld_grumpf.hope-2000.org).
bhyve: don't crash when guest writes TPM int_enable register
Nov 12 2024, 7:56 AM
corvink committed rG1616f7d4b57b: bhyve: avoid a potential deadlock (authored by khorben).
bhyve: avoid a potential deadlock
Nov 12 2024, 7:56 AM
corvink committed rG660e7182dbee: bhyve: merge adjacent E820 entries (authored by corvink).
bhyve: merge adjacent E820 entries
Nov 12 2024, 7:56 AM
corvink committed rG541696f2a1d0: bhyve: remove empty E820 entries (authored by corvink).
bhyve: remove empty E820 entries
Nov 12 2024, 7:56 AM

Oct 22 2024

corvink committed rG08139140c5f9: bhyve: merge adjacent E820 entries (authored by corvink).
bhyve: merge adjacent E820 entries
Oct 22 2024, 12:19 PM
corvink closed D45336: bhyve: merge adjacent E820 entries.
Oct 22 2024, 12:19 PM
corvink committed rGd93fbcf0222b: bhyve: TPM 2.0 emulation with swtpm (authored by rosenfeld_grumpf.hope-2000.org).
bhyve: TPM 2.0 emulation with swtpm
Oct 22 2024, 12:07 PM
corvink committed rGbc3d09e90b86: bhyve: TPM CRB: pass actual TPM request length to backend execute_cmd() (authored by rosenfeld_grumpf.hope-2000.org).
bhyve: TPM CRB: pass actual TPM request length to backend execute_cmd()
Oct 22 2024, 12:07 PM
corvink committed rG2feea221b248: bhyve: don't crash when guest writes TPM int_enable register (authored by rosenfeld_grumpf.hope-2000.org).
bhyve: don't crash when guest writes TPM int_enable register
Oct 22 2024, 12:07 PM
corvink closed D46373: bhyve: TPM 2.0 emulation with swtpm.
Oct 22 2024, 12:07 PM
corvink closed D46564: bhyve: TPM CRB: pass actual TPM request length to backend execute_cmd().
Oct 22 2024, 12:07 PM
corvink closed D46562: bhyve: don't crash when guest writes TPM int_enable register.
Oct 22 2024, 12:07 PM

Sep 20 2024

corvink added a comment to D46562: bhyve: don't crash when guest writes TPM int_enable register.

Do I need a more elaborate commit message here, too?

Also, and in general, where do testing notes go, assuming they are needed?

Sep 20 2024, 7:02 AM

Sep 18 2024

corvink accepted D46564: bhyve: TPM CRB: pass actual TPM request length to backend execute_cmd().

Where's the commit message?

Sep 18 2024, 12:43 PM
corvink accepted D46562: bhyve: don't crash when guest writes TPM int_enable register.
Sep 18 2024, 12:40 PM
corvink accepted D45120: Add bhyve uart raw tcp backend.

It would be a very good idea to improve your commit message. It would be nice to explain the use case in more detail (if possible). Additionally, it would be great to mention limitations of this new feature e.g. that user have to make sure to protect the tcp socket from unprivileged access.

Sep 18 2024, 12:38 PM
corvink added a comment to D45340: bhyve: trap protected BAR regions of passthru devices.

ping

Sep 18 2024, 12:35 PM
corvink added a comment to D45339: bhyve: add BAR handler list for passthru devices.

ping

Sep 18 2024, 12:35 PM
corvink added a comment to D45337: bhyve: support VBTs which lay outside of the OpRegion.

ping

Sep 18 2024, 12:34 PM
corvink added a comment to D45336: bhyve: merge adjacent E820 entries.

ping

Sep 18 2024, 12:34 PM
corvink added a comment to D45333: x86/pci: add sysctl for intel_graphics_gen.

ping

Sep 18 2024, 12:33 PM