bhyve: trap protected BAR regions of passthru devices
Needs ReviewPublic
Actions

Authored by corvink on Fri, May 24, 11:34 AM.

Details

Reviewers

jhb
markj

Group Reviewers

bhyve

Summary

At the moment, the list of protected BAR regions is unused by the passthru
emulation. Make use of it when mapping the BAR regions. This causes bhyve to
trap those regions.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 58050
Build 54938: arc lint + arc unit

Event Timeline

corvink created this revision.Fri, May 24, 11:34 AM

Herald added subscribers: bcran, rgrimes, imp. · View Herald TranscriptFri, May 24, 11:34 AM

corvink requested review of this revision.Fri, May 24, 11:34 AM

Harbormaster completed remote builds in B57896: Diff 139037.Fri, May 24, 11:34 AM

corvink added a child revision: D45341: bhyve: add interface to protect BAR regions of passthru devices.Fri, May 24, 11:35 AM

corvink added a parent revision: D45339: bhyve: add BAR handler list for passthru devices.

markj added inline comments.Mon, May 27, 3:59 PM

usr.sbin/bhyve/pci_passthru.c
1270–1271	Have you tried using tools/build/checkstyle9.pl?
1300

fix style issues

Harbormaster completed remote builds in B58050: Diff 139424.Tue, Jun 4, 8:34 AM

corvink marked 2 inline comments as done.Tue, Jun 4, 8:36 AM

corvink added inline comments.

usr.sbin/bhyve/pci_passthru.c
1270–1271	Wasn't aware of this helper tool. I'm always using the top level .clang-format. Unfortunately, it seems to be incorrect for some cases.

Revision Contents
Changeset List

Path

Size

usr.sbin/

bhyve/

pci_passthru.c

61 lines

Diff 139424

View Options

usr.sbin/bhyve/pci_passthru.c

bhyve: trap protected BAR regions of passthru devicesNeeds ReviewPublicActions