bhyve: add interface to protect BAR regions of passthru devices
Needs ReviewPublic
Actions

Authored by corvink on May 24 2024, 11:34 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Jun 17, 12:47 PM

	Unknown Object (File)
	Fri, Jun 13, 11:11 AM

	Unknown Object (File)
	Fri, Jun 13, 10:47 AM

	Unknown Object (File)
	Thu, Jun 12, 6:05 PM

	Unknown Object (File)
	Wed, Jun 11, 8:42 PM

	Unknown Object (File)
	Wed, Jun 11, 1:43 AM

	Unknown Object (File)
	Fri, May 23, 4:49 AM

	Unknown Object (File)
	Apr 28 2025, 1:07 AM

Subscribers

Details

Reviewers

jhb
markj

Group Reviewers

bhyve

Summary

We need an interface for protecting BAR regions to make it easier to use this
feature and to make it usable by external emulations like the GVT-d emulation.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 64802
Build 61686: arc lint + arc unit

Event Timeline

corvink created this revision.May 24 2024, 11:34 AM

Herald added subscribers: bcran, rgrimes, imp. · View Herald TranscriptMay 24 2024, 11:34 AM

corvink requested review of this revision.May 24 2024, 11:34 AM

Harbormaster completed remote builds in B57897: Diff 139038.May 24 2024, 11:34 AM

corvink added a child revision: D45342: bhyve: protect MMIO mapped BDSM register.May 24 2024, 11:35 AM

corvink added a parent revision: D45340: bhyve: trap protected BAR regions of passthru devices.

rebase onto main

Harbormaster completed remote builds in B64802: Diff 156885.Thu, Jun 12, 1:46 PM

markj added inline comments.Tue, Jun 17, 12:27 PM

usr.sbin/bhyve/pci_passthru.c
778
usr.sbin/bhyve/pci_passthru.h
57	Again I'm not sure why the vm_* types are appropriate here, bhyve appears to use uint64_t for mmio addresses, so this should be consistent.