Page MenuHomeFreeBSD
Differential D45341

bhyve: add interface to protect BAR regions of passthru devices
ClosedPublic
Actions

Authored by corvink on May 24 2024, 11:34 AM.
Tags
None
Referenced Files
F157204666: D45341.diff
Tue, May 19, 7:41 AM
F157203970: D45341.diff
Tue, May 19, 7:37 AM
Unknown Object (File)
Sun, May 17, 7:36 AM
Unknown Object (File)
Fri, May 15, 1:39 PM
Unknown Object (File)
Fri, May 15, 1:14 PM
Unknown Object (File)
Fri, May 15, 1:29 AM
Unknown Object (File)
Thu, May 14, 11:03 PM
Unknown Object (File)
Thu, May 14, 7:53 PM
View All Files
Subscribers
bcran
imp
rgrimes

Details

Reviewers
jhb
markj
Group Reviewers
bhyve
Commits
rG6dda2653bd0e: bhyve: add interface to protect BAR regions of passthru devices
Summary

We need an interface for protecting BAR regions to make it easier to use this
feature and to make it usable by external emulations like the GVT-d emulation.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

corvink created this revision.May 24 2024, 11:34 AM
Herald added subscribers: bcran, rgrimes, imp. · View Herald TranscriptMay 24 2024, 11:34 AM
corvink requested review of this revision.May 24 2024, 11:34 AM
Harbormaster completed remote builds in B57897: Diff 139038.May 24 2024, 11:34 AM
corvink added a child revision: D45342: bhyve: protect MMIO mapped BDSM register.May 24 2024, 11:35 AM
corvink added a parent revision: D45340: bhyve: trap protected BAR regions of passthru devices.
corvink updated this revision to Diff 156885.Jun 12 2025, 1:46 PM
  • rebase onto main
Harbormaster completed remote builds in B64802: Diff 156885.Jun 12 2025, 1:46 PM
markj added inline comments.Jun 17 2025, 12:27 PM
usr.sbin/bhyve/pci_passthru.c
779
usr.sbin/bhyve/pci_passthru.h
57

Again I'm not sure why the vm_* types are appropriate here, bhyve appears to use uint64_t for mmio addresses, so this should be consistent.

corvink updated this revision to Diff 157702.Jun 27 2025, 7:40 AM
  • use uint64_t instead of vm_* types
Harbormaster completed remote builds in B65116: Diff 157702.Jun 27 2025, 7:40 AM
corvink marked 2 inline comments as done.Jun 27 2025, 8:07 AM
jhb accepted this revision.Jun 30 2025, 6:31 PM
This revision is now accepted and ready to land.Jun 30 2025, 6:31 PM
Closed by commit rG6dda2653bd0e: bhyve: add interface to protect BAR regions of passthru devices (authored by corvink). · Explain WhyAug 5 2025, 2:04 PM
This revision was automatically updated to reflect the committed changes.
corvink added a commit: rG6dda2653bd0e: bhyve: add interface to protect BAR regions of passthru devices.

Revision Contents
Changeset List

PathSize
usr.sbin/
bhyve/
3 lines
39 lines

Diff 159778

View Options

usr.sbin/bhyve/pci_passthru.h

Loading...
View Options

usr.sbin/bhyve/pci_passthru.c

Loading...