Page MenuHomeFreeBSD
Differential D45341

bhyve: add interface to protect BAR regions of passthru devices
AcceptedPublic
Actions

Authored by corvink on May 24 2024, 11:34 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jul 12, 10:30 PM
Unknown Object (File)
Mon, Jul 7, 7:10 AM
Unknown Object (File)
Fri, Jul 4, 12:37 AM
Unknown Object (File)
Tue, Jul 1, 8:12 PM
Unknown Object (File)
Sun, Jun 29, 7:18 PM
Unknown Object (File)
Thu, Jun 26, 5:06 AM
Unknown Object (File)
Wed, Jun 25, 11:43 PM
Unknown Object (File)
Thu, Jun 19, 8:24 AM
View All 51 Files
Subscribers
bcran
imp
rgrimes

Details

Reviewers
jhb
markj
Group Reviewers
bhyve
Summary

We need an interface for protecting BAR regions to make it easier to use this
feature and to make it usable by external emulations like the GVT-d emulation.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 65116
Build 61999: arc lint + arc unit

Event Timeline

corvink created this revision.May 24 2024, 11:34 AM
Herald added subscribers: bcran, rgrimes, imp. · View Herald TranscriptMay 24 2024, 11:34 AM
corvink requested review of this revision.May 24 2024, 11:34 AM
Harbormaster completed remote builds in B57897: Diff 139038.May 24 2024, 11:34 AM
corvink added a child revision: D45342: bhyve: protect MMIO mapped BDSM register.May 24 2024, 11:35 AM
corvink added a parent revision: D45340: bhyve: trap protected BAR regions of passthru devices.
corvink updated this revision to Diff 156885.Jun 12 2025, 1:46 PM
  • rebase onto main
Harbormaster completed remote builds in B64802: Diff 156885.Jun 12 2025, 1:46 PM
markj added inline comments.Tue, Jun 17, 12:27 PM
usr.sbin/bhyve/pci_passthru.c
778
usr.sbin/bhyve/pci_passthru.h
57

Again I'm not sure why the vm_* types are appropriate here, bhyve appears to use uint64_t for mmio addresses, so this should be consistent.

corvink updated this revision to Diff 157702.Fri, Jun 27, 7:40 AM
  • use uint64_t instead of vm_* types
Harbormaster completed remote builds in B65116: Diff 157702.Fri, Jun 27, 7:40 AM
corvink marked 2 inline comments as done.Fri, Jun 27, 8:07 AM
jhb accepted this revision.Mon, Jun 30, 6:31 PM
This revision is now accepted and ready to land.Mon, Jun 30, 6:31 PM

Revision Contents
Changeset List

PathSize
usr.sbin/
bhyve/
3 lines
39 lines

Diff 157702

View Options

usr.sbin/bhyve/pci_passthru.h

Loading...
View Options

usr.sbin/bhyve/pci_passthru.c

Loading...