This commit isn't staged in a tree.

I'm able to boot a Windows guest without -w by applying this patch.

• Use IA32_FEATURE_CONTROL_LOCK define

• rebase

• rebase

In D26209#656996, @khng wrote:

In D26209#656995, @c.koehne_beckhoff.com wrote:

I'm going to rebase this patch soon.

The change is upstreamed. You could integrate it with main without integrating your own D24066.

I'm going to rebase this patch soon.

In D27970#630024, @bcran wrote:

One person on Slack said they'd like the BAR in a fixed (high) location, so I wouldn't be confident committing this without other people (e.g. @jhb and @grehan ) reviewing it too.

• Rebase onto main
• It's possible to load a Video-BIOS from a file now

• fix compiling

• Works with new OVMF (see D27230) now

• Rebase onto 13-CURRENT

• Use new UEFI provided by D27230

• Revert rS367606 "bhyve: avoid allocating BARs above the end of supported physical addresses."

The alignment depends on gUefiOvmfPkgTokenSpaceGuid.PcdPciMmio64Size which is set in BhyveX64.dsc. On my system with 4 GB of RAM, it's set to 32 GB:
GetFirstNonAddress: Pci64Base=0x800000000 Pci64Size=0x800000000

GCD map depends on gUefiOvmfPkgTokenSpaceGuid.PcdPciMmio64Base and gUefiOvmfPkgTokenSpaceGuid.PcdPciMmio64Size which are set at OvmfPkg/Bhyve/PlatformPei/MemDetect.c (GetFirstNonAddress):

On my system this EFI version will fail, if a 64-bit BAR above 4 GB is used. GCD-Memory doesn't covers the MMIO-Space above 4 GB:

Updates:

• Implement GVT-d emulation as passthru device.
• Include D24066 for easier testing (will be removed as soon as it's merged)

In D27456#613548, @darkfiberiru_gmail.com wrote:

Are there any technical limitations that make this specific to AMD GPU?

Fix code style of comments

In D26506#594727, @grehan wrote:

The work is at https://www.gulbra.net/freebsd-bhyve/

You'd need to extract the PCI ROM BIOS support. I can help or even do that.

Updates:

• Reuse D24066

In D26506#592106, @grehan wrote:

Generic PCI ROM BIOS support in EFI might be a better solution for this (there is a version posted in the vga-bios patches a while back), with ROM extraction being a separate issue.

Updates:

• Use an own device emulation for GVT-d
• Do not modify the current implementation of passthru devices

Fixed Issues:

1. Do not patch cfgread and cfgwrite of passthru devices:

The device emulation functions are shared by every passthru device.
If igd emulationen patches it's cfgread and cfgwrite functions, it will be changed for every passthru device too.
To avoid this, add a passthru_type to decide which function to take.

Add copyright header to new file "pci_igd_lpc.c"

Fixed Issues:

1. register_bar and unregister_bar functions doesn't handle MSI-X BAR properly

Thank's for your feedback.

Glad to hear that it works on your system.

Thanks for your detailed description.

In D26209#585065, @wanpengqian_gmail.com wrote:

I want to test this patch. Currently, I am using a Lenovo M920Q with i5 8400T, 16G RAM, and 2 SSDs.

What is PM support? I cannot find anything similar in BIOS settings.

Updates:

• Use PCI-MMIO-Space (0xC0000000 - 0xE0000000) for allocation of Opregion and Graphics Stolen Memory
• Increase size of Opregion to 16 kB
• Detect size of Graphics Stolen Memory

In D26209#582340, @grehan wrote:

The Intel ACRN edk2 fork has a GVT GOP driver that may be suitable

https://github.com/projectacrn/acrn-edk2/tree/ovmf-acrn/OvmfPkg/GvtGopDxe