vmm: Factor most of sysctl_vmm_create() out into a separate function
ClosedPublic
Actions

Authored by markj on Aug 27 2024, 12:04 AM.

Details

Reviewers

corvink
jhb

Group Reviewers

bhyve

Commits

rGd58197097610: vmm: Factor most of sysctl_vmm_create() out into a separate function

Summary

This will make it easy to share code with an ioctl handler which creates
VMs. No functional change intended.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Aug 27 2024, 12:04 AM

Herald added a subscriber: imp. · View Herald TranscriptAug 27 2024, 12:04 AM

markj requested review of this revision.Aug 27 2024, 12:04 AM

markj added a child revision: D46445: vmm: Factor most of sysctl_vmm_destroy() into a separate function.

Harbormaster completed remote builds in B59188: Diff 142472.Aug 27 2024, 12:04 AM

corvink accepted this revision.Aug 28 2024, 6:38 AM

This revision is now accepted and ready to land.Aug 28 2024, 6:38 AM

jhb accepted this revision.Aug 28 2024, 4:40 PM

jhb added a subscriber: jhb.

jhb added inline comments.

sys/dev/vmm/vmm_dev.c
888	Should we convert this to use make_dev_s in a followup to close the race with setting si_drv1?

markj added inline comments.Aug 28 2024, 4:59 PM

sys/dev/vmm/vmm_dev.c
888	Yes, that's a good idea.

Closed by commit rGd58197097610: vmm: Factor most of sysctl_vmm_create() out into a separate function (authored by markj). · Explain WhyAug 28 2024, 7:13 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rGd58197097610: vmm: Factor most of sysctl_vmm_create() out into a separate function.

Revision Contents
Changeset List

Path

Size

sys/

dev/

vmm/

vmm_dev.c

86 lines

Diff 142570

View Options

vmm: Factor most of sysctl_vmm_create() out into a separate functionClosedPublicActions