Agree on using PAGE_SIZE for everyone. Most likely more controllers have this issue (even within Crucial model range), so it is a way easier to align to page_size all of them rather than deal with bug reports from users. We are a general purpose OS.
And again, Linux align to PAGE_SIZE all of them as well.

rename macro

The issue arise on Crucial P310 only, so convert to a quirk

looks redundant. thanks

What I see when 32 byte requested it actually gives us PAGE_SIZE aligned address, which works.

Good points. I will check with Codasip if this is something to do with CHERI (I don't see any connection however)

Thanks @pkelsey. I will look at this once again (I did not forget about this but need to restore my CVA6 setup).

Regenerate

Add hwt.4 to the build and create MLINKS

In D51192#1169501, @ziaee wrote:

https://man-dev.freebsd.org/vt
And in current (not synced to web interface yet), check out uftdi, uchcom, or pf

rework SYNOPSIS

improve HOOKS section

Address @ziaee comments

reorder

Spelling

Fix issues found by mandoc lint

• take run time linker path from ELF binary rather than from INTERP record
• address ziaee's comments

Restore "unlock the vnode around the exec hook call"

Style.

do not unlock image text vnode

Add SCHED_4BSD hwt hooks

• Move ELF image activator hooks to generic kern_exec.c
• HWT_HOOKS: Move variable declarations under the if()
• HWT_HOOKS: Move contents of kern_hwt.c to kern_pmc.c
• Remove VM_ALLOC_NOBUSY flag from vm_page_alloc_contig() request to meet KASSERTs in vm_page.c

Regenerate. Fix P2_HWT

Regenerate

hwt_fmt added

Regenerate

handle return code of OF_getencprop() correctly

Remove 0

Address @jrtc27 comments.

Fix error mask settings when CRC is disabled

the hack around MMC return code is now resolved by @pkelsey

In D49248#1132893, @pkelsey wrote:

It does detect the card with your patch, but size is 0bytes (CSD is zero)

mmc0: New card detected (CID 035344534236344780da29024a014400)
mmc0: New card detected (CSD 00000200000000000000000000000000)

I am looking if I can find an issue...

I checked all of the response type mappings against the spec again and found a mistake where I had indexed into the wrong table for the SEND_CSD and SEND_CID translations when making this patch. Attached is a new version that corrects those mappings (as well as corrects another mapping for an SPI-only command, although that change has no functional effect). I expect this will sort out the issue you are observing.

mmcspi.c55 KBDownload

In D49248#1132271, @pkelsey wrote:

@pkelsey Could you add permission to the file uploaded, so I can download.

@br I wasn't aware of that - I think it's resolved now.

In D49248#1132215, @pkelsey wrote:

mmcspi.c55 KBDownload

I've uploaded a version of this file that removes the R7 translation hack and fixes the underlying issue as I've proposed. I did not compile this code, so please excuse any mechanical issues that you find. The SPI response type to SD/MMC response type correspondence that has been added here corresponds to what the code implemented prior to the commit I referenced above, and I double checked it for each command against the current version of the SD Physical Layer Simplified Specification.

Fix comments per @pkelsey request