In D49248#1132271, @pkelsey wrote:

@pkelsey Could you add permission to the file uploaded, so I can download.

@br I wasn't aware of that - I think it's resolved now.

In D49248#1132215, @pkelsey wrote:

mmcspi.c55 KBDownload

I've uploaded a version of this file that removes the R7 translation hack and fixes the underlying issue as I've proposed. I did not compile this code, so please excuse any mechanical issues that you find. The SPI response type to SD/MMC response type correspondence that has been added here corresponds to what the code implemented prior to the commit I referenced above, and I double checked it for each command against the current version of the SD Physical Layer Simplified Specification.

Fix comments per @pkelsey request

Address @markj comments. Thanks, Mark!

Address @jrtc27 comments

Add spinlock around DOMAINCFG acccess.

Add clock-frequency property to UART instead of defining fixed-clock

style: end of function return SUCCESS unless switch statement hit FAILURE

Resubmit updated patch

• Remove $FreeBSD$ tags
• Remove unused include headers
• Check if HWT hooks are installed before constructing data structures

Address @jrtc27 and @markj comments (Thanks!)

Address @markj comments

Switch coresight to EL2 otherwise it does not trace CPU mode.

In D40466#1056428, @andrew wrote:

How do you handle different conflicting modes? e.g. a user is tracing a pid & another tries to enable thread tracing. The hardware may not be able to perform both operations.

Prevent tracing the same proc by multiple users.

In D40477#957268, @andrew wrote:

This doesn't build when I add hwt and coresight to my kernel config

Due to pipeline design Coresight components could not be used for more than 1 concurrent tracing sessions.
Atomic counter of sessions added and limited to 1.

Use delayed children attach.
It seems the PHY needs extra 500ms to initialize before we probe for devices. Otherwise PCIB could not find a device (Intel NVME in my case).
So instead of waiting for 500ms, postpone the bus enumeration.

In D48133#1097519, @jrtc27 wrote:

Wait so you put up a patch to disable Sstc before an alternative was provided?

make reset driver optional
remove dtbs build

remove extra retval check

use snprintf() to ensure we don't overwrite buffer available

Per @mhorne suggestion, add device_get_unit() check;
Get virtual address of memory resource using rman_get_virtual().

add const qualifier to char *isa

Per @markj suggestion, construct the ISA string in the bhyve_init_platform() and then pass ready-to-use string to FDT code

In D48058#1095266, @jrtc27 wrote:

Do we really want one vm_cap_type entry per extension?

Add missing context!