riscv vmm: SBI timer support
ClosedPublic
Actions

Authored by br on Dec 18 2024, 4:06 PM.

Details

Reviewers

mhorne
jrtc27
markj

Group Reviewers

bhyve

Commits

rG9be0058ea0fc: riscv vmm: virtual timer support.

Summary

Add SBI timer implementation and rework interrupts handling.

This is needed for EIC7700 which does not have SSTC extension supported.

Add new "interrupts_pending" field. Use it for timer interrupt only for now, but later we can extend to store all pending interrupts (IPI and External).

Test Plan

With this I'm able to boot SMP guest on HiFive Premier P550.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

br created this revision.Dec 18 2024, 4:06 PM

Herald added a reviewer: bhyve. · View Herald TranscriptDec 18 2024, 4:06 PM

Herald added subscribers: riscv, bcran, rgrimes. · View Herald Transcript

br requested review of this revision.Dec 18 2024, 4:06 PM

Wait so you put up a patch to disable Sstc before an alternative was provided?

In D48133#1097519, @jrtc27 wrote:

Wait so you put up a patch to disable Sstc before an alternative was provided?

:-)
Well it was still working in QEMU and Spike that both have SSTC.
On EIC7700 I needed to disable SSTC advertisement before I can work on SBI timer...otherwise the guest runs an invalid instruction.

This revision was not accepted when it landed; it landed in state Needs Review.Jan 2 2025, 4:05 PM

Closed by commit rG9be0058ea0fc: riscv vmm: virtual timer support. (authored by br). · Explain Why

This revision was automatically updated to reflect the committed changes.

br added a commit: rG9be0058ea0fc: riscv vmm: virtual timer support..

Herald added a subscriber: imp. · View Herald TranscriptJan 2 2025, 4:05 PM