Page MenuHomeFreeBSD

riscv: zicbom extension support
ClosedPublic

Authored by br on Apr 16 2025, 3:00 PM.
Tags
None
Referenced Files
F142054842: D49852.id153734.diff
Thu, Jan 15, 1:20 PM
Unknown Object (File)
Thu, Jan 15, 4:24 AM
Unknown Object (File)
Thu, Jan 15, 2:58 AM
Unknown Object (File)
Wed, Jan 14, 1:06 PM
Unknown Object (File)
Sat, Jan 10, 6:07 AM
Unknown Object (File)
Fri, Jan 9, 12:19 PM
Unknown Object (File)
Tue, Dec 30, 4:00 PM
Unknown Object (File)
Fri, Dec 26, 10:20 PM
Subscribers

Details

Summary

Detect zicbom extension and install cache invalidation handlers

Test Plan

The extension found on Codasip X730 and required by AXI DMA engine driver

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

br requested review of this revision.Apr 16 2025, 3:00 PM
sys/conf/kern.mk
166 ↗(On Diff #153732)

You shouldn't just do that unconditionally. Just .option push; .option arch, +zicbom ... .option pop in asm that needs it.

sys/riscv/riscv/cbo.c
48

0 can be dropped for all these, and does the singular operand really need to be named? %0 is fine, surely?

sys/riscv/riscv/identcpu.c
228–229

Obsolete?

354–357

OF_getencprop can fail. But also why not just pass sizeof(desc->foo) and let it check the length for you?

handle return code of OF_getencprop() correctly

This revision was not accepted when it landed; it landed in state Needs Review.Apr 22 2025, 9:07 AM
This revision was automatically updated to reflect the committed changes.