Page MenuHomeFreeBSD

riscv: zicbom extension support
ClosedPublic

Authored by br on Apr 16 2025, 3:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, May 11, 3:56 AM
Unknown Object (File)
Sat, May 10, 4:17 PM
Unknown Object (File)
Fri, May 9, 9:34 AM
Unknown Object (File)
Wed, May 7, 8:22 AM
Unknown Object (File)
Mon, May 5, 7:37 AM
Unknown Object (File)
Sun, May 4, 3:52 PM
Unknown Object (File)
Fri, May 2, 1:24 PM
Unknown Object (File)
Apr 30 2025, 1:09 AM
Subscribers

Details

Summary

Detect zicbom extension and install cache invalidation handlers

Test Plan

The extension found on Codasip X730 and required by AXI DMA engine driver

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

br requested review of this revision.Apr 16 2025, 3:00 PM
sys/conf/kern.mk
166 ↗(On Diff #153732)

You shouldn't just do that unconditionally. Just .option push; .option arch, +zicbom ... .option pop in asm that needs it.

sys/riscv/riscv/cbo.c
48

0 can be dropped for all these, and does the singular operand really need to be named? %0 is fine, surely?

sys/riscv/riscv/identcpu.c
228–229

Obsolete?

354–357

OF_getencprop can fail. But also why not just pass sizeof(desc->foo) and let it check the length for you?

handle return code of OF_getencprop() correctly

This revision was not accepted when it landed; it landed in state Needs Review.Apr 22 2025, 9:07 AM
This revision was automatically updated to reflect the committed changes.