In D22367#504144, @gordon wrote:I don't think secteam is the right reviewer for this change. Has this been reviewed by folks on the freebsd-net mailing list?
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Jan 7 2020
Jan 7 2020
Jan 2 2020
Jan 2 2020
pdk_semihalf.com added a comment to D22368: Improve sequence number overflow detection in AH protocol.
@secteam Do you have any objections to this patch?
@secteam Do you have any objections to this patch?
Nov 22 2019
Nov 22 2019
Added checking if pointer to reply structure is not NULL
Nov 18 2019
Nov 18 2019
pdk_semihalf.com added a comment to D22363: Increase number of algorithms that can be initialized in cryptosoft.
It is considered as an algorithm to avoid ESN implementation in every driver (I have implemented ESN in cryptosoft and aesni only).
It would be perfect if OCF was prepared for ESN support or at least was organized in way that makes ESN implementation simpler than in current OCF.
Nov 15 2019
Nov 15 2019
Nov 14 2019
Nov 14 2019
pdk_semihalf.com added a reviewer for D22370: Trigger soft lifetime expiration on sequence number: jmg.
pdk_semihalf.com added a reviewer for D22369: Add support for IPSec ESN and pass relevant information to crypto layer: jmg.
pdk_semihalf.com added a reviewer for D22368: Improve sequence number overflow detection in AH protocol: jmg.
pdk_semihalf.com added a reviewer for D22367: Implement anti-replay algorithm with ESN support: jmg.
Jul 9 2018
Jul 9 2018
Removed unnecessary changes
Jun 26 2018
Jun 26 2018
Do you have still objections to this patch?
Do you have still objections to this patch?
Jun 22 2018
Jun 22 2018
Remove redundant ecam quirk.
Added obtaining ecam and bus number from ACPI. This allows us to remove ThunderX2 quirk connected with ecam.
Jun 21 2018
Jun 21 2018
pdk_semihalf.com added inline comments to D15928: Add ThunderX2 CPU revision macro. Add ThunderX2 name in identcpu.c.
Remove unused declarations.
Move quirks form acpi part to common part.
Jun 20 2018
Jun 20 2018
Links to patches emerged
Macros: https://reviews.freebsd.org/D15928
Quirks: https://reviews.freebsd.org/D15929
No functional changes. This is the previous patch with quirks and macros moved, as andrew suggested
Jun 12 2018
Jun 12 2018
Restore previous statement about Foundation sponsorship
May 21 2018
May 21 2018
Remove unused functions and declarations.
May 18 2018
May 18 2018
Do you have any objections to this patch?
Apr 26 2018
Apr 26 2018
Fixed all issues pointed by manu
Apr 25 2018
Apr 25 2018
Changed approach we add resources to rman. Clean unnecessary changes.
Apr 24 2018
Apr 24 2018
This is not final version!
It is good idea to provide support using quirks, however pci_host_generic_acpi still needs some resource allocation changes. I have limited ability to check if it doesn't break another devices, so from my point of view it is safe to provide separate driver.
Of course I will follow your advices, but I'm depending on you to perform review very carefully.
Apr 20 2018
Apr 20 2018
Mar 1 2018
Mar 1 2018
In D14538#305338, @nwhitehorn wrote:In D14538#305284, @pdk_semihalf.com wrote:I have a question about your 1st worry. Is this a scenario in which we are doing memcpy in eg. interrupt filter code? If not, could you explain what are you worry about?
Suppose we have an altivec- (or VSX-)using userland program. Vector registers on PPC, like all other architectures, are not saved and restored by interrupt handler code. Instead, they are only saved/restored by cpu_switch() and only if PCB_VEC is set. If a userland thread makes a syscall or otherwise ends up in the kernel, I do not see how this avoids clobbering the vector register state of the userland process. Is there something I am missing?
I have a question about your 1st worry. Is this a scenario in which we are doing memcpy in eg. interrupt filter code? If not, could you explain what are you worry about?
Feb 27 2018
Feb 27 2018
Feb 21 2018
Feb 21 2018
pdk_semihalf.com updated the diff for D14330: PowerNV: Put processor to power-save state in idle thread.
pdk_semihalf.com updated the diff for D14330: PowerNV: Put processor to power-save state in idle thread.
pdk_semihalf.com updated the diff for D14330: PowerNV: Put processor to power-save state in idle thread.
Added some checks, which detects situation when SRR1 is set to inappropriate value (eg. QEMU)
pdk_semihalf.com updated the diff for D14330: PowerNV: Put processor to power-save state in idle thread.
pdk_semihalf.com added a comment to D14330: PowerNV: Put processor to power-save state in idle thread.
I wanted this file to be cpu.c equivalent but in assembler, that's why it was named cpu.S
I'd rather keep it cpu_subr64.S because in the near future I want to put highly optimized memcpy into it.
Feb 20 2018
Feb 20 2018
pdk_semihalf.com updated the diff for D14330: PowerNV: Put processor to power-save state in idle thread.
pdk_semihalf.com added inline comments to D14330: PowerNV: Put processor to power-save state in idle thread.
pdk_semihalf.com added inline comments to D14330: PowerNV: Put processor to power-save state in idle thread.
pdk_semihalf.com updated the diff for D14330: PowerNV: Put processor to power-save state in idle thread.
Updated diff. I think it will be the last one
Feb 19 2018
Feb 19 2018
pdk_semihalf.com updated the diff for D14433: PowerPC: Switch to more accurate unit to avoid division rounding.
Changed type of ps_per_tick to uint64_t
pdk_semihalf.com added a comment to D14330: PowerNV: Put processor to power-save state in idle thread.
In D14330#302615, @nwhitehorn wrote:In D14330#302546, @pdk_semihalf.com wrote:Could you tell me more about scenario in which we branch to rstcode from software? I was looking for it but I found nothing.
Line 99 of locore64.S.
pdk_semihalf.com added a comment to D14330: PowerNV: Put processor to power-save state in idle thread.
Could you tell me more about scenario in which we branch to rstcode from software? I was looking for it but I found nothing.
pdk_semihalf.com updated the diff for D14330: PowerNV: Put processor to power-save state in idle thread.
pdk_semihalf.com added inline comments to D14330: PowerNV: Put processor to power-save state in idle thread.
Feb 16 2018
Feb 16 2018
pdk_semihalf.com added inline comments to D14330: PowerNV: Put processor to power-save state in idle thread.
pdk_semihalf.com updated the diff for D14330: PowerNV: Put processor to power-save state in idle thread.
Feb 15 2018
Feb 15 2018
pdk_semihalf.com added a comment to D14330: PowerNV: Put processor to power-save state in idle thread.
Thanks for your response.
pdk_semihalf.com updated the diff for D14330: PowerNV: Put processor to power-save state in idle thread.
pdk_semihalf.com added a comment to D14330: PowerNV: Put processor to power-save state in idle thread.
Do you have any objections to this patch?
Feb 12 2018
Feb 12 2018
Jan 24 2018
Jan 24 2018
pdk_semihalf.com updated the diff for D14023: BPF: Switch to 32 bit compatible mode only when thread is 32 bit.
Completely changed patch. It uses hint provided by andrew.
Jan 23 2018
Jan 23 2018
pdk_semihalf.com added a comment to D14023: BPF: Switch to 32 bit compatible mode only when thread is 32 bit.
My first approach was simply avoid fallback when 64 bit and 32 bit ioctl are equal. But it was terrible idea.
If you thought more about this issue, you would realize that problem is in calculating ioctl number and recognizing 32 bit ioctl using sizeof.
Sooner or later breaking ioctl ABI will be necessary.
pdk_semihalf.com added a comment to D14023: BPF: Switch to 32 bit compatible mode only when thread is 32 bit.
Almost all 32 bit ioctl work. In BPF there is BIOCSRTIMEOUT (takes timeval as argument) and BIOCSRTIMEOUT32 (takes timeval32 as argument) which are equal on non intel arch.
That ioctl works only on amd64 because timeval32 has size of 8 bytes. But on other arch, timeval32 has size of 12 bytes (16 bytes with padding)
pdk_semihalf.com updated the summary of D14023: BPF: Switch to 32 bit compatible mode only when thread is 32 bit.
Sep 11 2017
Sep 11 2017
Sep 7 2017
Sep 7 2017
Sep 4 2017
Sep 4 2017