Page MenuHomeFreeBSD

Fix loader bug causing too many pages allocation when bootloader is U-Boot
ClosedPublic

Authored by mw on Aug 31 2017, 10:28 PM.
Tags
Referenced Files
Unknown Object (File)
Wed, Aug 26, 7:48 AM
Unknown Object (File)
Tue, Aug 25, 6:28 AM
Unknown Object (File)
Mon, Aug 17, 2:41 AM
Unknown Object (File)
Tue, Aug 11, 8:06 PM
Unknown Object (File)
Sat, Aug 8, 4:59 PM
Unknown Object (File)
Wed, Aug 5, 1:06 PM
Unknown Object (File)
Wed, Aug 5, 9:08 AM
Unknown Object (File)
Wed, Aug 5, 4:39 AM

Details

Summary

FreeBSD loader expects to have mmsz variable set by bootloader.
U-Boot behaviour is that if buffer size is not big enough to keep
whole memory map, assign the smallest correct buffer size to sz
and return error.

In other words U-Boot assumes that nobody will need mmsz value when buffer
is not filled with memory map, which is not true, so calculated pages value
was too big to allocate.

Solution: Simply assign default value to mmsz.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Hi @imp , any objections to the patch?

I have no objection, but am curious if we ever need to honor the mmsz.

sys/boot/efi/loader/bootinfo.c
275 โ†—(On Diff #32564)

Is this always the size, or are there cases we need to honor what uboot does set?

sys/boot/efi/loader/bootinfo.c
275 โ†—(On Diff #32564)

It is always the size, see this .

This revision was automatically updated to reflect the committed changes.