Hi, is there anything still blocking this review?

In D18757#422029, @kai wrote:

• File a bug for tracking the KDE-inotify bug.

If I'm not mistaken the Chromium Bug-Tracker is the right platform for that bug?

Thank you very much for this patch. I think we're good to go, and the KDE inotify thing can be tracked separately. I haven't test-built the latest version of this patch in older releases like 11.2 though, it'd be good to do the following:

Damn, I forgot to mention this review in the commit message :( Landed in rP496820.

Thanks a lot for working on this. I've left some inline comments in some of the patches, but there isn't a lot that I think needs changing \o/

In D18757#420567, @kai wrote:

Add missing debug files in pkg-plist.

In D19629#420289, @tcberner wrote:

We should look into only build depending on ecm now for the desktop ports.

In D19575#419906, @rakuco wrote:

In D19575#419887, @fluffy wrote:

Please add pkgconfig to dependencies for gnomekeyring

I'll do that separately since it's also a build-time dependency.

In D19575#419887, @fluffy wrote:

In D19575#419878, @rakuco wrote:

Do not bump PORTREVISION

Please add pkgconfig to dependencies for gnomekeyring

Do not bump PORTREVISION

friendly ping?

Quick update on LibreSSL: apparently it's already broken

Update my email address in the first patch.

Thanks, I think I've addressed both of your points in this update.

Include bsd.port.options.mk, simplify plist substitutions

Looks fine to me; I haven't tested it myself but I trust the work being done here.

ping

Yeah. It's something good to have, but I don't have time to pursue this one.

Looks OK to me. It'd be good to clean this up and submit the patch upstream later.