Page MenuHomeFreeBSD

graphics/ilmbase: Simplify pthread workaround.
ClosedPublic

Authored by rakuco on Mar 25 2019, 12:43 PM.

Details

Reviewers
mandree
Summary

Improve upon rP496818. Instead of setting both MAKE_ENV and patching ilmthread's Makefile, just make sure PTHREAD_LIBS is set a configuration time. This is what Debian does, and it achieves the same solution with fewer lines.

While here, add an explanation for why we need this.

Test Plan

The port still builds fine and links correctly against libthr.so.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 23285
Build 22317: arc lint + arc unit

Event Timeline

rakuco created this revision.Mar 25 2019, 12:43 PM
mandree accepted this revision.Mar 25 2019, 12:57 PM

please commit

This revision is now accepted and ready to land.Mar 25 2019, 12:57 PM
rakuco closed this revision.Mar 25 2019, 1:01 PM

Damn, I forgot to mention this review in the commit message :( Landed in rP496820.