Page MenuHomeFreeBSD

www/falkon: Drop linguist_build from USE_QT
ClosedPublic

Authored by rakuco on Mar 13 2019, 9:38 PM.

Details

Summary

This was added in rP493225 without a clear explanation. There are no mentions of linguist in the source code, and testbuilding the port without it also works fine.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

rakuco created this revision.Mar 13 2019, 9:38 PM
Harbormaster completed remote builds in B23070: Diff 55037.
tcberner accepted this revision.Mar 17 2019, 7:33 AM
tcberner added a subscriber: tcberner.

lgtm as long as it builds

This revision is now accepted and ready to land.Mar 17 2019, 7:33 AM
fluffy added a subscriber: fluffy.Mar 17 2019, 10:31 AM

Take a break, guys.

USES+= pkgconfig to build with gnomekeyring support

mat added a comment.Mar 17 2019, 10:38 AM

You don't need to bump PORTREVISION if you only remove a build-time dependency.

rakuco updated this revision to Diff 55151.Mar 17 2019, 11:47 AM

Do not bump PORTREVISION

This revision now requires review to proceed.Mar 17 2019, 11:47 AM
fluffy added a comment.EditedMar 17 2019, 1:02 PM

Do not bump PORTREVISION

Please add pkgconfig to dependencies for gnomekeyring

Do not bump PORTREVISION

Please add pkgconfig to dependencies for gnomekeyring

I'll do that separately since it's also a build-time dependency.

This revision was not accepted when it landed; it landed in state Needs Review.Mar 17 2019, 2:17 PM
This revision was automatically updated to reflect the committed changes.

Please add pkgconfig to dependencies for gnomekeyring

I'll do that separately since it's also a build-time dependency.

Done in rP496081, thanks.