Page MenuHomeFreeBSD
Differential D19575

www/falkon: Drop linguist_build from USE_QT
ClosedPublic
Actions

Authored by rakuco on Mar 13 2019, 9:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 2, 9:09 AM
Unknown Object (File)
Tue, Apr 2, 9:09 AM
Unknown Object (File)
Tue, Apr 2, 9:09 AM
Unknown Object (File)
Tue, Apr 2, 9:09 AM
Unknown Object (File)
Tue, Apr 2, 8:52 AM
Unknown Object (File)
Sat, Mar 23, 12:27 PM
Unknown Object (File)
Jan 27 2024, 9:19 AM
Unknown Object (File)
Jan 27 2024, 9:19 AM
View All 40 Files
Subscribers
fluffy
mat
tcberner

Details

Reviewers
adridg
tcberner
Group Reviewers
kde
Commits
rP496063: Remove linguist_build from USE_QT.
Summary

This was added in rP493225 without a clear explanation. There are no mentions of linguist in the source code, and testbuilding the port without it also works fine.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 23139
Build 22192: arc lint + arc unit

Event Timeline

rakuco created this revision.Mar 13 2019, 9:38 PM
Herald added a subscriber: mat. · View Herald TranscriptMar 13 2019, 9:38 PM
Harbormaster completed remote builds in B23070: Diff 55037.Mar 13 2019, 9:38 PM
Harbormaster completed remote builds in B23070: Diff 55037.
tcberner accepted this revision.Mar 17 2019, 7:33 AM
tcberner added a subscriber: tcberner.

lgtm as long as it builds

This revision is now accepted and ready to land.Mar 17 2019, 7:33 AM
fluffy added a subscriber: fluffy.Mar 17 2019, 10:31 AM

Take a break, guys.

USES+= pkgconfig to build with gnomekeyring support

mat added a comment.Mar 17 2019, 10:38 AM

You don't need to bump PORTREVISION if you only remove a build-time dependency.

rakuco updated this revision to Diff 55151.Mar 17 2019, 11:47 AM

Do not bump PORTREVISION

This revision now requires review to proceed.Mar 17 2019, 11:47 AM
Harbormaster completed remote builds in B23139: Diff 55151.Mar 17 2019, 11:47 AM
fluffy added a comment.EditedMar 17 2019, 1:02 PM
In D19575#419878, @rakuco wrote:

Do not bump PORTREVISION

Please add pkgconfig to dependencies for gnomekeyring

rakuco added a comment.Mar 17 2019, 2:15 PM
In D19575#419887, @fluffy wrote:
In D19575#419878, @rakuco wrote:

Do not bump PORTREVISION

Please add pkgconfig to dependencies for gnomekeyring

I'll do that separately since it's also a build-time dependency.

This revision was not accepted when it landed; it landed in state Needs Review.Mar 17 2019, 2:17 PM
Closed by commit rP496063: Remove linguist_build from USE_QT. (authored by rakuco). · Explain Why
This revision was automatically updated to reflect the committed changes.
rakuco added a comment.Mar 17 2019, 6:07 PM
In D19575#419906, @rakuco wrote:
In D19575#419887, @fluffy wrote:

Please add pkgconfig to dependencies for gnomekeyring

I'll do that separately since it's also a build-time dependency.

Done in rP496081, thanks.

Revision Contents
Changeset List

PathSize
www/
falkon/
2 lines

Diff 55151

View Options

www/falkon/Makefile

Loading...