Page MenuHomeFreeBSD

audio/kscd-kde4 use support track lookup with audio/libmusicbrainz5
ClosedPublic

Authored by jhale on Jul 31 2018, 8:43 PM.

Details

Summary

The webservice provided by audio/libmusicbrainz3 will cease operation
on 2018-08-01. This patch made from several commits from KDE git ports the
track lookup functionality to audio/libmusicbrainz5 and audio/libdiscid.

I figured a monolithic patch would be a little cleaner since we're probably
not going to see many more KDE4 releases, but if there is a new release of kscd,
one patch file to delete would a little simpler. But, I can split the patch if
it really bugs somebody.

Should probably be MFH'd as well.

Test Plan

Poudriere tests successful on 10.4-i386, 11.1-amd64, 12-CURRENT-amd64
Run tested with several CDs - seems to work.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jhale created this revision.Jul 31 2018, 8:43 PM
rakuco accepted this revision.Jul 31 2018, 8:49 PM
rakuco added a subscriber: rakuco.

Looks fine to me; I haven't tested it myself but I trust the work being done here.

This revision is now accepted and ready to land.Jul 31 2018, 8:49 PM
This revision was automatically updated to reflect the committed changes.