This fixes bug 236613, which happens when the KWALLET option is disabled. In this case, we do not pull in devel/qt5-linguisttools even though Falkon's build system uses e-c-m's ECMPoQmTools.cmake, which requires linguisttools to be present. As it turns out, we need to run-depend on linguisttools to prevent this kind of issue anywhere.
Details
Details
- Reviewers
tcberner - Group Reviewers
kde - Commits
- rP496209: MFH: r496208
rP496208: Depend on qt5-linguisttools at runtime too.
Falkon built correctly with KWALLET disabled.
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
We should look into only build depending on ecm now for the desktop ports. -- On the other hand, linguisttools is also rather lean in dependencies...
Comment Actions
Isn't that orthogonal? Even if e-c-m was a build-time dependency, www/falkon would still fail to configure.
Comment Actions
I meant additionally, to your patch here -- as ecm would be pulled in at build, and with it linguisttool.
However ports now mostly use USE_KDE=ecm (as the cmake files they install are broken without ecm present, and therefore break development work on FreeBSD if kf5-extra-cmake-modules is not installed as well).