Page MenuHomeFreeBSD

devel/kf5-extra-cmake-modules: Depend on qt5-linguisttools at runtime too

Authored by rakuco on Mar 18 2019, 8:50 PM.



This fixes bug 236613, which happens when the KWALLET option is disabled. In this case, we do not pull in devel/qt5-linguisttools even though Falkon's build system uses e-c-m's ECMPoQmTools.cmake, which requires linguisttools to be present. As it turns out, we need to run-depend on linguisttools to prevent this kind of issue anywhere.

Test Plan

Falkon built correctly with KWALLET disabled.

Diff Detail

rP FreeBSD ports repository
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

tcberner added a subscriber: tcberner.

We should look into only build depending on ecm now for the desktop ports. -- On the other hand, linguisttools is also rather lean in dependencies...

This revision is now accepted and ready to land.Mar 18 2019, 8:55 PM

We should look into only build depending on ecm now for the desktop ports.

Isn't that orthogonal? Even if e-c-m was a build-time dependency, www/falkon would still fail to configure.

I meant additionally, to your patch here -- as ecm would be pulled in at build, and with it linguisttool.

However ports now mostly use USE_KDE=ecm (as the cmake files they install are broken without ecm present, and therefore break development work on FreeBSD if kf5-extra-cmake-modules is not installed as well).

This revision was automatically updated to reflect the committed changes.