If the note is below the example, consider that approved as well (remember the blank line in between).

I'll commit this shortly.

Please go ahead and commit with my approval.

Thanks Mat- sometimes the best answer is completely different! I'll build both versions and install them alongside each other- in a package this size, flavours are overkill.

Great, will commit, thanks.

Manpage and usage changes look fine.

Hello portmgr,

Inline.

Apart from line 36's removal, all looks good.

OK, Mat's feedback incorporated.

NO_FETCH isn't actually a thing of course.

Poudriere builds both no problem:

Create slave port -lib to install everything except the symlink, and change devel/arcanist to only install the bin symlink

Yeah, I wondered what would happen about the php flavours :(

Nope, CONFLICTS has changed its behaviour, so remove the globs entirely.

Just realised, the CONFLICTS line should have [0-9] in it.

Thanks very much for the explanation-- I think my terminology is just off here (I do understand what you mean). I have some ideas to get this to work, but I'll get back when I've tried them, may not be for a few days.

I've reverted the patch for now (thanks again Jilles for your approval).

Fantastic, thanks for the approval and tip.

In D18670#425443, @rgrimes wrote:

I have performed a visual only review.

At the risk of hijacking this conversation, I don't remember where I put my copy of the patch, but i remember it working correctly! Please go ahead and commit, it won't hurt :)

Thanks @bcr- had it open anyway.

Unlees @bcr commits it first or objects, I'll do it.

@rene, would you still like rmport patched? I can't remember why I reverted it.

I think it should be NRTbdehnotqx, shouldn't it? I'm sure most of our manpages are like that.

Committed, thanks!

Please get the MAX fixed too and it's great.

I think this should work-- how have you tested this?

Docs approval not necessarily needed, but given for a green tick there.

I would assume that people with their own repo will understand that the default options case doesn't apply to them, so that final comment is probably OK.

Looks great, thanks!

Would you still prefer a different fix? I'm not quite sure how to work around this!