Page MenuHomeFreeBSD

Remove legacy rc.d infrastructure references
ClosedPublic

Authored by ngie on Dec 28 2018, 1:41 AM.

Details

Summary

Legacy rc.d scripts (.sh extension) have not been supported since
r193118. Remove the outdated references to the legacy format, as they
are no longer valid.

Bug: 193936
MFC after: 1 week

Test Plan

n/a

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ngie created this revision.Dec 28 2018, 1:41 AM
crees accepted this revision.Dec 28 2018, 7:56 AM
crees added inline comments.
share/man/man8/rc.8
34 ↗(On Diff #52355)

Today.

162 ↗(On Diff #52355)

Did you mean to remove this bit?

This revision is now accepted and ready to land.Dec 28 2018, 7:56 AM

FYI if you prefix the rev number with rS instead of r (i.e., rS193118) Phabricator will make a link out of it - it's a bit of an oddity, but rather convenient.

LGTM other than the points @crees made.

ngie marked an inline comment as done.EditedDec 29 2018, 6:44 PM

FYI if you prefix the rev number with rS instead of r (i.e., rS193118) Phabricator will make a link out of it - it's a bit of an oddity, but rather convenient.

I agree and understand when strictly dealing with the context of Phabricator. However, I try to keep consistent with the VCS-specific notation so it's easier to figure out the commit version later on -- otherwise it will make finding revisions in svnweb.freebsd.org, etc, harder :/.

I wish we annotated commits with their review revision numbers like FB's Phabricator does.

share/man/man8/rc.8
162 ↗(On Diff #52355)

I didn't -- thank you for catching this!

ngie updated this revision to Diff 52400.Dec 29 2018, 6:53 PM
ngie marked an inline comment as done.

Update per comments from @crees

I try to avoid .Dd updates until I commit manpage changes (since the actual
commit date can vary), but for the purpose of this review, I'm including
them.

This revision now requires review to proceed.Dec 29 2018, 6:53 PM
crees accepted this revision.Dec 29 2018, 7:49 PM

Looks great, thanks!

This revision is now accepted and ready to land.Dec 29 2018, 7:49 PM
This revision was automatically updated to reflect the committed changes.