Remove legacy rc.d infrastructure references
ClosedPublic
Actions

Authored by ngie on Dec 28 2018, 1:41 AM.

Details

Reviewers

crees
emaste
jtl

Group Reviewers

manpages

Commits

rS342597: Remove legacy rc.d infrastructure references from rc(8)

Summary

Legacy rc.d scripts (.sh extension) have not been supported since
r193118. Remove the outdated references to the legacy format, as they
are no longer valid.

Bug: 193936
MFC after: 1 week

Test Plan

n/a

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 21765
Build 21040: arc lint + arc unit

Event Timeline

ngie created this revision.Dec 28 2018, 1:41 AM

Harbormaster completed remote builds in B21749: Diff 52355.Dec 28 2018, 1:42 AM

crees accepted this revision.Dec 28 2018, 7:56 AM

crees added inline comments.

share/man/man8/rc.8
34	Today.
162	Did you mean to remove this bit?

This revision is now accepted and ready to land.Dec 28 2018, 7:56 AM

FYI if you prefix the rev number with rS instead of r (i.e., rS193118) Phabricator will make a link out of it - it's a bit of an oddity, but rather convenient.

LGTM other than the points @crees made.

In D18666#398456, @emaste wrote:

FYI if you prefix the rev number with rS instead of r (i.e., rS193118) Phabricator will make a link out of it - it's a bit of an oddity, but rather convenient.

I agree and understand when strictly dealing with the context of Phabricator. However, I try to keep consistent with the VCS-specific notation so it's easier to figure out the commit version later on -- otherwise it will make finding revisions in svnweb.freebsd.org, etc, harder :/.

I wish we annotated commits with their review revision numbers like FB's Phabricator does.

share/man/man8/rc.8
162	I didn't -- thank you for catching this!

Update per comments from @crees

I try to avoid .Dd updates until I commit manpage changes (since the actual
commit date can vary), but for the purpose of this review, I'm including
them.

This revision now requires review to proceed.Dec 29 2018, 6:53 PM

Harbormaster completed remote builds in B21765: Diff 52400.Dec 29 2018, 6:53 PM

Looks great, thanks!

This revision is now accepted and ready to land.Dec 29 2018, 7:49 PM

Closed by commit rS342597: Remove legacy rc.d infrastructure references from rc(8) (authored by ngie). · Explain WhyDec 29 2018, 8:02 PM

This revision was automatically updated to reflect the committed changes.

Herald added a reviewer: manpages. · View Herald TranscriptDec 29 2018, 8:02 PM

Herald added a subscriber: imp. · View Herald Transcript