Page MenuHomeFreeBSD
Differential D7048

Add and document DOLLAR variable to allow $ symbols while automounting Samba shares
ClosedPublic
Actions

Authored by crees on Jul 1 2016, 8:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 2, 2:07 PM
Unknown Object (File)
Mon, Dec 2, 2:07 PM
Unknown Object (File)
Mon, Dec 2, 2:07 PM
Unknown Object (File)
Mon, Dec 2, 1:56 PM
Unknown Object (File)
Sat, Nov 30, 1:26 PM
Unknown Object (File)
Wed, Nov 27, 12:44 PM
Unknown Object (File)
Nov 21 2024, 1:53 AM
Unknown Object (File)
Nov 18 2024, 1:13 AM
View All 64 Files
Subscribers
bcr
imp

Details

Reviewers
trasz
bcr
Group Reviewers
manpages
Commits
rS342573: There is no way of escaping literal $ signs in auto_master(5), which
Summary

I've written a script for automounting Samba shares, but automountd chokes on the $ in some Samba shares. I can't find any workaround other than -DDOLLAR=\$ in automountd_flags (great idea to have that option!), but I think it would be handy to have anyway.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

crees updated this revision to Diff 18059.Jul 1 2016, 8:42 PM
crees retitled this revision from to Add and document DOLLAR variable to allow $ symbols while automounting Samba shares.
crees updated this object.
crees edited the test plan for this revision. (Show Details)
crees added a reviewer: trasz.
Herald added a reviewer: manpages. · View Herald TranscriptJul 1 2016, 8:42 PM
Herald added a subscriber: imp. · View Herald Transcript
trasz edited edge metadata.Jul 23 2016, 7:31 AM

I'd prefer to just fix the code that's breaking it. It looks like it's a result of overzealous escaping somewhere...

crees added a comment.Jul 23 2016, 7:45 AM
In D7048#151670, @trasz wrote:

I'd prefer to just fix the code that's breaking it. It looks like it's a result of overzealous escaping somewhere...

It results from Samba hidden shares having a $ in, and from my casual reading of the code \$ is not escaped?

I agree that putting $ into a share name is annoying, but unfortunately it's been done for years!

The other solution would be to allow \$ as an escape.

crees added a comment.Dec 23 2018, 9:41 AM

Would you still prefer a different fix? I'm not quite sure how to work around this!

trasz accepted this revision.Dec 27 2018, 1:19 PM

Hi. Sorry it took so long; I think the fix is ok. Thanks!

This revision is now accepted and ready to land.Dec 27 2018, 1:19 PM
bcr accepted this revision.Dec 27 2018, 2:38 PM
bcr added a subscriber: bcr.

Don't forget to bump the .Dd at the beginning of the man page to today's date as this is a content change. Thanks!

Closed by commit rS342573: There is no way of escaping literal $ signs in auto_master(5), which (authored by crees). · Explain WhyDec 28 2018, 3:11 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
usr.sbin/
autofs/
4 lines
1 line

Diff 52369

View Options

head/usr.sbin/autofs/auto_master.5

Loading...
View Options

head/usr.sbin/autofs/defined.c

Loading...